Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Apr 2016 01:34:21 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298607 - head/sys/dev/ath
Message-ID:  <201604260134.u3Q1YL7e091434@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Tue Apr 26 01:34:21 2016
New Revision: 298607
URL: https://svnweb.freebsd.org/changeset/base/298607

Log:
  [ath] obey the STBC flag setting in iv_flags_ht
  
  Add support for the FHT_STBC_TX flag in iv_flags_ht, so it'll now obey
  the per-vap ifconfig stbctx flag.
  
  This means that we can do STBC TX on one vap and not another VAP.
  (As well as STBC RX on said vap; that changes the HTCAP announcement.)

Modified:
  head/sys/dev/ath/if_ath_tx_ht.c

Modified: head/sys/dev/ath/if_ath_tx_ht.c
==============================================================================
--- head/sys/dev/ath/if_ath_tx_ht.c	Tue Apr 26 01:30:29 2016	(r298606)
+++ head/sys/dev/ath/if_ath_tx_ht.c	Tue Apr 26 01:34:21 2016	(r298607)
@@ -272,8 +272,11 @@ ath_tx_rate_fill_rcflags(struct ath_soft
 			 * can receive (at least) 1 stream STBC, AND it's
 			 * MCS 0-7, AND we have at least two chains enabled,
 			 * enable STBC.
+			 *
+			 * XXX TODO: .. and the rate is an 11n rate?
 			 */
 			if (ic->ic_htcaps & IEEE80211_HTCAP_TXSTBC &&
+			    ni->ni_vap->iv_flags_ht & IEEE80211_FHT_STBC_TX &&
 			    ni->ni_htcap & IEEE80211_HTCAP_RXSTBC_1STREAM &&
 			    (sc->sc_cur_txchainmask > 1) &&
 			    HT_RC_2_STREAMS(rate) == 1) {
@@ -281,10 +284,6 @@ ath_tx_rate_fill_rcflags(struct ath_soft
 			}
 
 			/*
-			 * XXX TODO: LDPC
-			 */
-
-			/*
 			 * Dual / Triple stream rate?
 			 */
 			if (HT_RC_2_STREAMS(rate) == 2)
@@ -565,6 +564,12 @@ ath_rateseries_setup(struct ath_softc *s
 		}
 
 		/*
+		 * TODO: If we're all doing 11n rates then we can set LDPC.
+		 * If we've been asked to /do/ LDPC but we are handed a
+		 * legacy rate, then we should complain.  Loudly.
+		 */
+
+		/*
 		 * PktDuration doesn't include slot, ACK, RTS, etc timing -
 		 * it's just the packet duration
 		 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604260134.u3Q1YL7e091434>