From owner-cvs-src@FreeBSD.ORG Wed Aug 3 11:31:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A85C16A41F; Wed, 3 Aug 2005 11:31:53 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from postfix4-1.free.fr (postfix4-1.free.fr [213.228.0.62]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD90143D45; Wed, 3 Aug 2005 11:31:52 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98]) by postfix4-1.free.fr (Postfix) with ESMTP id F1918319DB7; Wed, 3 Aug 2005 13:31:50 +0200 (CEST) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id AA986405B; Wed, 3 Aug 2005 13:32:08 +0200 (CEST) Date: Wed, 3 Aug 2005 13:32:08 +0200 From: Jeremie Le Hen To: Alexander Leidinger Message-ID: <20050803113208.GG45385@obiwan.tataz.chchile.org> References: <20050731102343.35bc4aa9@Magellan.Leidinger.net> <20050802090717.GK14023@ip.net.ua> <20050802140536.zstn68rcgsg84g0w@netchild.homeip.net> <20050802.085239.34568854.imp@bsdimp.com> <20050803121150.gn025733y8400wk8@netchild.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050803121150.gn025733y8400wk8@netchild.homeip.net> User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, ru@FreeBSD.org, grehan@FreeBSD.org, des@des.no, "M. Warner Losh" Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2005 11:31:53 -0000 Hi, On Wed, Aug 03, 2005 at 12:11:50PM +0200, Alexander Leidinger wrote: > "M. Warner Losh" wrote: > > >In message: <20050802140536.zstn68rcgsg84g0w@netchild.homeip.net> > > Alexander Leidinger writes: > >: When an user calls delete-old with DESTDIR set to the root of a > >non-native > >: machine architecture he may remove non-obsolete files when he > >forgets to set > >: TARGET_ARCH. I want to prevent this situation. I think "failsafe" is more > >: important than "POLA" in this case. > > > >If TARGET_ARCH is set, then the right set of files will be deleted if > >you use TARGET_ARCH rather than MACHINE_ARCH. > > Yes. I'm not talking about technical problems. I talk about problems which > sit on a chair. If we change MACHINE_ARCH to TARGET_ARCH and an user runs > "make delete-old-libs" without setting TARGET_ARCH in a cross-arch > environment, he will remove non-obsolete libs. And I think we should go the > failsafe route. > > If you think we can life with this problem, go ahead and change MACHINE_ARCH > to TARGET_ARCH. But add an explanation to the commit log which makes it > obvious that you understand the problem I'm talking about and that we > (FreeBSD) don't care about it. And be prepared that I will whine at the > person which makes this change when someone shoots in his foot when he > forgets to set TARGET_ARCH. What about making TARGET_ARCH mandatory if DESTDIR is different from "/" ? Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >