From owner-freebsd-current@freebsd.org Wed Aug 29 15:19:05 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45EA0108CD35 for ; Wed, 29 Aug 2018 15:19:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B7E35710E3 for ; Wed, 29 Aug 2018 15:19:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf1-x430.google.com with SMTP id p12-v6so2431682pfh.2 for ; Wed, 29 Aug 2018 08:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8naAvaGDsNXwl7SWtjW8ujGvwL0Q4OBFReEmmzPLDU4=; b=jKK1RJjb3Yz38PFIYMikO3EdB03QPzaH+QnCM1pbp4ZnWOJ2ll/gTWzIEDfJmvghCW EYgQ/8/uN0n5fpnsMYC1cB2crpF7YTlg6x/RVIT2o5+ujyC+wiuRISo6z5E+0qrFCpRv jPz6NlyMkH/d9LPoaN9OOchGdThsFJajiNrBbHSVUQIV/f8pA1YQRoCF7tUug7ia4Qmq KyjGkHxVaZecaqfJluXfymJr9132OmhDcmStiJh4KiAETal6KaQ2uW8zF8gWWCBYJuN9 fvI6PSfg1Tvqs315f4Cl/49tv9ze4lsy7lyZXdFSiTcBznHmHTadV1d4/37ZsSRAgj6+ nlaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=8naAvaGDsNXwl7SWtjW8ujGvwL0Q4OBFReEmmzPLDU4=; b=YR1Bt1myqGzEfHB5Y4bHKwsa1Gu9oHOKoGwyUtl2ohaLTR5q1ydMXj05A7B0ylYw84 u3blZgyznbIOAEJT4wsGNr+Qg6beVx0YHo7Th0B9jH1jf43dhuYOceoSe7nGg2JDOyh6 q6X1JMnO226jZnmpGj59Fd784Tw7xuMY+CCbq7m7y3M1kHYRTLjcPYqhR2g186THpozr IqkMaR3q7/DG45SCqeesoi89RJhW6Ws4/4Iie4rQciDH6zceGvs7EFDg1OMBgDEwFVQE lprRvMSrO52jVoiyRkWy4TEL1TeU07u4OpFSS8+WGN9JL+Km2hHobBgMzXQ7xwX2IJH3 5fxQ== X-Gm-Message-State: APzg51A4h2iGIJpNPBYKYKNlXwPqTRGspGvARAKDPTkuQgeBEAXe9/tk ms5IHR0xg9W6u+JtShzj8ALv1xlft6M= X-Google-Smtp-Source: ANB0VdaCfRlhrBqzcKAsW7yMypwhawber+ZfoFr/YHOp517bN8M3CippdxR2APC1zFPHwzOnZ1q7JA== X-Received: by 2002:a62:8186:: with SMTP id t128-v6mr6367554pfd.192.1535555943483; Wed, 29 Aug 2018 08:19:03 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id q26-v6sm13391958pfj.127.2018.08.29.08.19.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 08:19:02 -0700 (PDT) Sender: Mark Johnston Date: Wed, 29 Aug 2018 11:18:57 -0400 From: Mark Johnston To: Alexander Leidinger Cc: freebsd-current@freebsd.org Subject: Re: old top and new -current: missing arcstat sysctl Message-ID: <20180829151857.GA2709@raichu> References: <20180828084015.Horde.JUeG828X_SDlJjeJdfmH7pV@webmail.leidinger.net> <20180828144842.GA29917@raichu> <20180829074431.Horde.NYx7i7jvhNMNuTj-hSYfzSk@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180829074431.Horde.NYx7i7jvhNMNuTj-hSYfzSk@webmail.leidinger.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 15:19:05 -0000 On Wed, Aug 29, 2018 at 07:44:31AM +0200, Alexander Leidinger wrote: > > Quoting Mark Johnston (from Tue, 28 Aug 2018 > 10:48:42 -0400): > > > On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: > >> On 2018-08-28 02:40, Alexander Leidinger wrote: > >> > Hi, > >> > > >> > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > >> > 12.0-alpha3 with a top from an old-ish -current. > >> > > >> > Is/will this be handled via a compat-11 sysctl (my kernel is without > >> > compat-xx), or did this slip through? > > >> That is not something that a compat-xx package can handle. > > > > s/package/kernel option/? > > Sorry, the COMPAT_FREEBSDx kernel options was what I had in mind when > I wrote this. > > >> That arcstat was broken up into 3 individual stats, which the > >> 12.0-alpha3 version of top will sum together for you. > >> > >> I don't think we've had compat shims like this for previous versions of > >> top, I recall having similar issues when the 'laundry' counter was > >> introduced. > > > > IIRC that would have been the inverted case of running a newer top(1) > > with an older kernel lacking the v_laundry_pages sysctl. In general I'd > > expect us to support running an older top(1) with newer kernels if we > > don't have to bend over backwards to provide compatibility. > > If the new top is summing the 3 up anyway, it sounds like we could > provide the old one as backwards compatibility, even if it is > redundant. I rather have an redundant counter and an old top working > (in the generic case of what we promise to our users; in this specific > case for me I just need to get around to update the jails on the > corresponding systems), than bailing out without displaying anything. I'm inclined to agree, especially since this (running older top(1)s) has come up before when I removed some VM sysctls: https://reviews.freebsd.org/D16943