From owner-svn-src-stable-9@FreeBSD.ORG Sat Feb 9 16:52:57 2013 Return-Path: Delivered-To: svn-src-stable-9@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B8C39222 for ; Sat, 9 Feb 2013 16:52:57 +0000 (UTC) (envelope-from andrey@zonov.org) Received: from mail-la0-x235.google.com (la-in-x0235.1e100.net [IPv6:2a00:1450:4010:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id 418A3246 for ; Sat, 9 Feb 2013 16:52:57 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id fr10so4619397lab.26 for ; Sat, 09 Feb 2013 08:52:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :x-gm-message-state; bh=iOCjVlkxu+ICmR2zeI4AD5dMu3D/x1v0hwFHhEb8eI4=; b=IbzuYLtova/8dWfCsAZJjRcpBEmvRltc6yYJastpnB/uOvGUeuxlOhx2QdWi5mauDr IqD/cLInilTCBrWHjaB4xaUc0OF1DW4VG/Um8UFWfIxXFk9ztyc3eUHXxspdHP1HEDD4 HLvnTO/hjvP3ZGsMFB80KURBbg6KlV4KgE6pYoUDgR2L7r5Dw4Q9jB6Anwj+4jB21Yax xefY5MEX3l88sL1t+FuGxPbHqSZ3y4ZQTVaijvJdYd+Nwl3xE04zlXhveFiXmAXxaDFs V4u50+b+NSL6Sej/hVH93lioMtI6Ndj2FEIwqSIhR2QestgQTZhZvC3dVU/3ifb49qqf ucVg== X-Received: by 10.152.145.37 with SMTP id sr5mr8212327lab.33.1360428776018; Sat, 09 Feb 2013 08:52:56 -0800 (PST) Received: from zont-osx.local (ppp95-165-158-215.pppoe.spdop.ru. [95.165.158.215]) by mx.google.com with ESMTPS id gm20sm3012080lab.7.2013.02.09.08.52.52 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 09 Feb 2013 08:52:54 -0800 (PST) Sender: Andrey Zonov Message-ID: <51167EDF.5010808@FreeBSD.org> Date: Sat, 09 Feb 2013 20:52:47 +0400 From: Andrey Zonov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Ian Lepore Subject: Re: svn commit: r246402 - stable/9/usr.sbin/inetd References: <201302061316.r16DGh6m024337@svn.freebsd.org> <1360159920.93359.594.camel@revolution.hippie.lan> In-Reply-To: <1360159920.93359.594.camel@revolution.hippie.lan> X-Enigmail-Version: 1.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2OANEGRQWNNVVETRRIOCV" X-Gm-Message-State: ALoCoQn60GA/Ezih0Fg+fRnxUYoAEKq/GkFdhzMqUw9ghCvMTKvI62ONCvVn3EZ5cF4ll5bnF0T7 Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2013 16:52:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OANEGRQWNNVVETRRIOCV Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2/6/13 6:12 PM, Ian Lepore wrote: > On Wed, 2013-02-06 at 13:16 +0000, Andrey Zonov wrote: >> Author: zont >> Date: Wed Feb 6 13:16:43 2013 >> New Revision: 246402 >> URL: http://svnweb.freebsd.org/changeset/base/246402 >> >> Log: >> MFC r245696: >> - Force inetd to have listen queue size to be set to the value of >> kern.ipc.somaxconn instead of hardcoded value 64. >> >> Modified: >> stable/9/usr.sbin/inetd/inetd.c >> Directory Properties: >> stable/9/usr.sbin/inetd/ (props changed) >> >> Modified: stable/9/usr.sbin/inetd/inetd.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- stable/9/usr.sbin/inetd/inetd.c Wed Feb 6 13:14:30 2013 (r246401)= >> +++ stable/9/usr.sbin/inetd/inetd.c Wed Feb 6 13:16:43 2013 (r246402)= >> @@ -1387,7 +1387,7 @@ setsockopt(fd, SOL_SOCKET, opt, (char *) >> } >> } >> if (sep->se_socktype =3D=3D SOCK_STREAM) >> - listen(sep->se_fd, 64); >> + listen(sep->se_fd, -1); >> enable(sep); >> if (debug) { >> warnx("registered %s on %d", >=20 > I recently discovered that the posix documentation for listen(2) states= > that a queue depth less than zero is to be treated as if zero were > specified, and the behavior for zero is to minimize the length of the > queue to the smallest value the implementation supports (with words tha= t > imply the desired (but not required) effect is to stop listening if > possible). >=20 Hm, I could not imagine that POSIX creates new shiny bike for that. > Given that, perhaps it's unwise to expand the amount of code we've got > that relies on this freebsd-specific non-conformance? >=20 I think it is BSD-specific and I like -1 more than INT_MAX here. Note that Linux is going crazy when you set backlog more than system limi= t. --=20 Andrey Zonov ------enig2OANEGRQWNNVVETRRIOCV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJRFn7iAAoJEBWLemxX/CvTczYH/jQn5WpJ6xWG6gTuUp0/HtLy qtoFeEb4D4G+cqx1SXYSgo6WinFdqx71daBCT18u1a0fPs4SBgMfMirLYW1Q1AeS FoPPaTsuoXo9I8ObmdJXyc1JLHUF0eDKp1So9qFUc6KWa+nDwrbnMRlp9B9rYzSo +kub1Hg8WmRpLsauNorfHsxEhsvq2NLIRwO6tEaeMy/YF0lX71nM7dY/esCFdeDU 0OajrNmmXA7tjrkyWGP95K2tMumQI3QRXGuBhjwgCRcGnEK8aXFY7zXs0EPpuxqd ANoIFOTAwQwjWtwOJVCfvkEIM+Bt6gGT4kPoB1DMT2o0P/0xyyRjLnP4LYcJLUw= =hmBk -----END PGP SIGNATURE----- ------enig2OANEGRQWNNVVETRRIOCV--