From owner-freebsd-acpi@FreeBSD.ORG Tue Feb 12 00:24:27 2008 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07BBE16A41A for ; Tue, 12 Feb 2008 00:24:27 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 8E77913C45E for ; Tue, 12 Feb 2008 00:24:26 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so646972uge.37 for ; Mon, 11 Feb 2008 16:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=IKz9wblogBLIuJkz1Bg8lLAa6LFjh697EKUVZL20GnY=; b=a1SEqbc1U2iDwoJW38cbp+vtP362XBQ5d3Hya39cUi+TiG21lEDsz5KjcUlzgGCBL6n2vMixX/JSuvZXC5S+wFp8XRMngii4r45nNF9wIAaAz9h/d0WHTy2U76pWAWcqXyBP5XCvYDHFuz0YB3eKfjQVorTBbrrIZpzpuALhT0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=HeR9Eok6F72Vp3BA1zTYTiQxMiYYKbs8EDwAkWXWDxNgTgvu8E4qZawfc1Kx4pJ2dYC6brP9Vebv/g7dkU3S7ObKjZydUb57cIWChwVGF7+4UlRSlLUM09q1gFzcrvT9nDrxEwKZrwcxRUcw3E7qQfxUdrNL7ttd0byqA+3K2tY= Received: by 10.66.241.13 with SMTP id o13mr805453ugh.57.1202774364371; Mon, 11 Feb 2008 15:59:24 -0800 (PST) Received: from ?89.214.138.1? ( [89.214.138.1]) by mx.google.com with ESMTPS id p10sm21294052gvf.8.2008.02.11.15.59.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Feb 2008 15:59:23 -0800 (PST) Message-Id: From: Rui Paulo To: Andriy Gapon In-Reply-To: <47B0BCA2.6040204@icyb.net.ua> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Mon, 11 Feb 2008 23:59:19 +0000 References: <47B0BCA2.6040204@icyb.net.ua> X-Mailer: Apple Mail (2.919.2) Sender: Rui Paulo Cc: freebsd-acpi@freebsd.org, njl@freebsd.org Subject: Re: probable typo in acpi_cpu.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2008 00:24:27 -0000 On Feb 11, 2008, at 9:22 PM, Andriy Gapon wrote: > > There is probably a typo in acpi_cpu.c, function acpi_cpu_startup: > if (cpu_quirks && CPU_QUIRK_NO_C3) { <----- here > sc->cpu_cx_count = sc->cpu_non_c3 + 1; > } > > Not sure how that affects the logic though. You are right. This means that the C3 state will still be available on systems like those based on PIIX4. Nate, could you please commit a fix for it? Regards. -- Rui Paulo