From nobody Wed Apr 10 16:26:47 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VF7WW2VHkz5HNgp; Wed, 10 Apr 2024 16:26:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VF7WW1ytmz465k; Wed, 10 Apr 2024 16:26:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712766407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LB/CfieW+yZeM54V5+ByS2BjGJKKo0+SXe4Tra5GwQc=; b=gAxANUvreLgOhwWrOcNGqanDYC+gyxAQNWyzpxrC01DcyPyeTWQP8iOBdFKOF7kC90ud3/ uPExQKpDYpuXLGCfaDKTEcBs+kgJ8JMbCkIOeGlkkRaLBtJk4Arn/BoNvYx1Qgx1EJ40ns ePhrfout/kRUPTsEFB9jx8K7vURBsCNa93rRPl9JXQX94q+h6RS5KiP3o0i94uTzaMcsvb XnML4kia/lKlSSb4vT0IKix9XEwmcPeCeGGR22tcauNC3yNy+jjnCz101sktg85fR7J5lC i3cTINpIMgxDUtetufYdDrug5UmMcrOuFcIT4grsZRCNzDb99plJeGnIKyNq9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712766407; a=rsa-sha256; cv=none; b=joBYTv0x9qA3KgCoiIiAlzCd9/a+Wr22wv3t7cbzeypR+iHU7tIsA81pnwU5toU0jz5osP aLsTIP6d7GPF2SGPItDX7mgYdkkok0NMth0Fz4Nqtl+1F16PEf0DMSyJoHiEE5M7GyV6vG eOLqtsLMiiPm2tixCxroap4UEJi4KVbeM9Is9sKXvXVQor0PhWaYCCSmIL3GzaVgJelyHt vZp+GCpC3Z6tct+gFUMaRIH8/NVhqqZE3m0pLHTGV0pEjXkGkobA+aMTv/RSxUndYgNnKc rk1OfPLAvxNB9LTNewTcPwUVezAs9+p3mPN6krVN7/XE84FyrWJMZaHUTyHfJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712766407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LB/CfieW+yZeM54V5+ByS2BjGJKKo0+SXe4Tra5GwQc=; b=rdOah6eckQz5xmVuVMy3X+NR/9p1kTzAQpDdq3ixmBjRuX3s/QmP0VUoaL3n6+O9ndVXcN DuDJOR9IBx40WN4A8xHGHDH6ZSot/tVHIz7Cdc0fYuFaxFB0hDa2OdziunK95x3eBNatfG sWnUvJJcxwvhUiS7DHKyE2E21YM8c79131hdhNLkaiyS/qLUF2n9Yo3zdEDuUzObFLU5OV PfXGPhsf/x3XQMubVNu+P/w/QJO6A1eUsKNJpaSjcTgGPVskPQ9cidKvQYAqkwvMmGhKcC ntKU94AmawT3vhaByf5VXOdK0R9ln1NLKB90CHEyFLSb3JEcgXdDFeYrnZXw6A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VF7WW1Ytyzl0v; Wed, 10 Apr 2024 16:26:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43AGQlpG012535; Wed, 10 Apr 2024 16:26:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43AGQloT012532; Wed, 10 Apr 2024 16:26:47 GMT (envelope-from git) Date: Wed, 10 Apr 2024 16:26:47 GMT Message-Id: <202404101626.43AGQloT012532@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 5c3c7500abd3 - main - x11-servers/xorg-server: Add upstream patch for xkbcomp directory List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: dev-commits-ports-all+owner@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5c3c7500abd37116903994674f562c603a29aec1 Auto-Submitted: auto-generated The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/ports/commit/?id=5c3c7500abd37116903994674f562c603a29aec1 commit 5c3c7500abd37116903994674f562c603a29aec1 Author: Emmanuel Vadot AuthorDate: 2024-04-09 15:25:10 +0000 Commit: Emmanuel Vadot CommitDate: 2024-04-10 16:26:43 +0000 x11-servers/xorg-server: Add upstream patch for xkbcomp directory Add a patch commited upstream but not present in any releases (except Xwayland ones) as xorg-server releases stopped a while ago. This adds a fallback to use $XDG_RUNTIME_DIR for xkbcomp result file if the user can't write to the configured directory, which is unlikely for xorg-server as it's SUID but it is likely for xephyr or xvfb. While here use the meson default for xkb_dir as it's the same as the one we provide and use also the default for xkb_output_dir which defaults to xkb_dir/compiled which is a link to /var/lib/xkb (setup by the xkeyboard-config port). Differential Revision: https://reviews.freebsd.org/D44697 Reviewed by: bapt Sponsored by: Beckhoff Automation GmbH & Co. KG --- x11-servers/xorg-server/Makefile | 6 +---- x11-servers/xorg-server/files/patch-xkb_ddxLoad.c | 30 +++++++++++++++++++++++ x11-servers/xorg-server/pkg-plist | 2 -- 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/x11-servers/xorg-server/Makefile b/x11-servers/xorg-server/Makefile index 9939340ec737..ec5deabbea4b 100644 --- a/x11-servers/xorg-server/Makefile +++ b/x11-servers/xorg-server/Makefile @@ -1,5 +1,6 @@ PORTNAME= xorg PORTVERSION= 21.1.12 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= x11-servers MASTER_SITES= XORG/individual/xserver @@ -34,7 +35,6 @@ PKGMESSAGE= BINARY_NAME= ${FLAVOR:C/^(.).*/\1/:tu}${FLAVOR:C/^.//} PLIST_FILES= bin/${BINARY_NAME} \ share/man/man1/${BINARY_NAME}.1.gz -PLIST_DIRS= /var/lib/xkb /var/lib .endif DESCR= ${.CURDIR}/pkg-descr-${FLAVOR} @@ -53,8 +53,6 @@ MESON_ARGS+= -Dxwin=false \ -Dfallback_input_driver=libinput \ -Ddocs=false \ -Dxcsecurity=true \ - -Dxkb_dir=${LOCALBASE}/share/X11/xkb \ - -Dxkb_output_dir=/var/lib/xkb \ -D${FLAVOR}=true .for f in ${FLAVORS:N${FLAVOR}} @@ -126,13 +124,11 @@ post-install: @${MKDIR} ${STAGEDIR}${PREFIX}/share/X11/xorg.conf.d @${INSTALL_DATA} ${FILESDIR}/20-evdev-kbd.conf \ ${STAGEDIR}${PREFIX}/share/X11/xorg.conf.d - ${MKDIR} -p ${STAGEDIR}/var/lib/xkb .else post-install: ${RM} -r ${STAGEDIR}${PREFIX}/lib/xorg/protocol.txt ${RMDIR} ${STAGEDIR}${PREFIX}/lib/xorg ${RM} ${STAGEDIR}${PREFIX}/share/man/man1/Xserver.1 - ${MKDIR} -p ${STAGEDIR}/var/lib/xkb .endif .include diff --git a/x11-servers/xorg-server/files/patch-xkb_ddxLoad.c b/x11-servers/xorg-server/files/patch-xkb_ddxLoad.c new file mode 100644 index 000000000000..509c70b6a680 --- /dev/null +++ b/x11-servers/xorg-server/files/patch-xkb_ddxLoad.c @@ -0,0 +1,30 @@ +--- xkb/ddxLoad.c.orig 2024-04-03 20:50:12 UTC ++++ xkb/ddxLoad.c +@@ -31,6 +31,7 @@ THE USE OR PERFORMANCE OF THIS SOFTWARE. + #include + + #include ++#include + #include + #include + #include +@@ -70,9 +71,17 @@ OutputDirectory(char *outdir, size_t size) + /* Can we write an xkm and then open it too? */ + if (access(XKM_OUTPUT_DIR, W_OK | X_OK) == 0) { + directory = XKM_OUTPUT_DIR; +- if (XKM_OUTPUT_DIR[strlen(XKM_OUTPUT_DIR) - 1] != '/') +- pathsep = "/"; ++ } else { ++ const char *xdg_runtime_dir = getenv("XDG_RUNTIME_DIR"); ++ ++ if (xdg_runtime_dir && xdg_runtime_dir[0] == '/' && ++ access(xdg_runtime_dir, W_OK | X_OK) == 0) ++ directory = xdg_runtime_dir; + } ++ ++ if (directory && directory[strlen(directory) - 1] != '/') ++ pathsep = "/"; ++ + #else + directory = Win32TempDir(); + pathsep = "\\"; diff --git a/x11-servers/xorg-server/pkg-plist b/x11-servers/xorg-server/pkg-plist index d99baab25f6b..b920012e58ba 100644 --- a/x11-servers/xorg-server/pkg-plist +++ b/x11-servers/xorg-server/pkg-plist @@ -189,5 +189,3 @@ share/X11/xorg.conf.d/20-evdev-kbd.conf share/aclocal/xorg-server.m4 @dir etc/X11/xorg.conf.d @dir %%FONTPATHD%% -@dir /var/lib/xkb -@dir /var/lib