From owner-svn-src-all@freebsd.org Sat Aug 4 22:46:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D4021056375 for ; Sat, 4 Aug 2018 22:46:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 335B78C9E9 for ; Sat, 4 Aug 2018 22:46:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x236.google.com with SMTP id g141-v6so13360964ita.4 for ; Sat, 04 Aug 2018 15:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TEBxRak4Dzg/R8aijnb8Fnsk1Mh7ERDSJ8uYtdiyI34=; b=NusJwOZCj9hqkPo/lfpilfPhV+sAOnRuWq9eMwfb2asxwiNki6bHQ2uHiAw0cb6s3F 8KVgTNmgWlYitvkNzPdmVfln2tUgdLb1zMP7yfBs47UNXmS2us6jMZdXhFu1wQeeGw8Y j+NZM6LPu30qHAdUuAvr+UXJU7BxALcE0+/mBFz8jDXP3zAbGI9S6SWkzGgi4aoEfHRV EtqqsecSXth4G/EH5l1qB25JeqoQGi1XCrwTJkM9OWkXT3LP1WEXg02A3BwMlc2fMcvL D0pChz+5jZn4PHYXQuOqmnNMK5aCsJ8YhW6IB2QH8HaURry+09gtQqoCnfw39UOumx2n hBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TEBxRak4Dzg/R8aijnb8Fnsk1Mh7ERDSJ8uYtdiyI34=; b=KdS1F4FRPSY4ksEhgzDtwXSPjJde3D3p51hvsYAwvFOIaR+U8ytXBhffzmRxpEcnGh VqXAbsTcT8cNu+joJR8f/X350i+K1Iq8RkhLPVZRfQpDbYG8TByE48GgJxn4rZt/N/Xt JiqelftU+SdwbCo+BVfYDceEzGDMCWpx3ItILtLdhwMhyIoZMxRJ9bilq4M+IHFpN2mC UeXCTpTCYLcTvSpGBnY7v/Gx93tk+ofJBWjWwaJpjvIxKMuj7SVwAwtVqjLb0V/ajVmV xAhPwH9kPzvH1zLDyLVRWoxOm5cw451o5Dq1G6Ni0WCpq/UlheHmd4yCDeByQJ6brnwH b2lg== X-Gm-Message-State: AOUpUlEJ3KWuKw963T2dEqcLYTv5PAl7uBoPFDd9eQmGWTx3iRTbFzPY j8VAxUG1OykHHHq1sZq3kklwFQ+XAKqtLRtAtfLR+g== X-Google-Smtp-Source: AAOMgpd7lbCYKHP66AoDsV9CmRUXlIoOPM1tRLatMRpll8M5ZgVxL893HiNVU8jqNpdTI3+p+ZaYHqZIGJDxAZpetqo= X-Received: by 2002:a24:4f52:: with SMTP id c79-v6mr10813378itb.36.1533422764529; Sat, 04 Aug 2018 15:46:04 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:4485:0:0:0:0:0 with HTTP; Sat, 4 Aug 2018 15:46:04 -0700 (PDT) X-Originating-IP: [86.153.210.77] In-Reply-To: <201808021925.w72JPhIu086582@repo.freebsd.org> References: <201808021925.w72JPhIu086582@repo.freebsd.org> From: Warner Losh Date: Sat, 4 Aug 2018 16:46:04 -0600 X-Google-Sender-Auth: 1M4XzTqz1Mk1B7eB0jL6Fbc88Sg Message-ID: Subject: Re: svn commit: r337165 - head/sys/fs/fuse To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 22:46:05 -0000 On Thu, Aug 2, 2018 at 1:25 PM, Conrad Meyer wrote: > Author: cem > Date: Thu Aug 2 19:25:43 2018 > New Revision: 337165 > URL: https://svnweb.freebsd.org/changeset/base/337165 > > Log: > FUSE: Bump maximum IO size to enable more performant operation > > Various components restrict size of IO passed up to the userspace > filesystem > based on the mount's f_iosize value. The previous default of PAGE_SIZE > is anemic, even for normal filesystems, but especially considering every > FUSE operation involves a kernel <-> userspace IPC upcall. > > Bump to DFLTPHYS (currently 64kB) to match other FUSE implementations. > > Anecdotally, Jakub reports IO read performance increased from 600 MB/s -> > 2700 MB/s with a basic RAM-backed FUSE filesystem. > > PR: 230260 > Reported by: Peter (MooseFS) > Tested by: Jakub Kruszona-Zawadzki > MFC after: 3 days > > Modified: > head/sys/fs/fuse/fuse_vfsops.c > > Modified: head/sys/fs/fuse/fuse_vfsops.c > ============================================================ > ================== > --- head/sys/fs/fuse/fuse_vfsops.c Thu Aug 2 19:19:53 2018 > (r337164) > +++ head/sys/fs/fuse/fuse_vfsops.c Thu Aug 2 19:25:43 2018 > (r337165) > @@ -341,7 +341,7 @@ fuse_vfsop_mount(struct mount *mp) > mp->mnt_kern_flag |= MNTK_USES_BCACHE; > MNT_IUNLOCK(mp); > /* We need this here as this slot is used by getnewvnode() */ > - mp->mnt_stat.f_iosize = PAGE_SIZE; > + mp->mnt_stat.f_iosize = DFLTPHYS; > Why DFLTPHYS instead of MAXPHYS? DFLTPHYS defaults to 64k, while MAXPHYS is 128k. Or do you expect people that want different behavior to raise both? Warner