Date: Wed, 29 May 2002 09:19:19 +0200 (CEST) From: Nick Hibma <n_hibma@van-laarhoven.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: FreeBSD CURRENT Mailing List <current@FreeBSD.ORG> Subject: Re: gdb52 patch for your .gdbinit files Message-ID: <20020529091727.G231-100000@heather.van-laarhoven.org> In-Reply-To: <20020529125101.K82424@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > As you can see, the patch is trivial, so I have no clue why this wasn't > > left alone when they modified symfile.c. If I can be bothered I'll > > submit it to them. > > Hmm. Looking at this patch, it seems it's complaining about being > handed a hex value where it's looking for an address. I'd guess that > this is in the wrong place. Where does it happen in the macros? Have a look at the gdb sources in FreeBSD-CURRENT and notice the fact that they removed the call to parse_and_eval_address and rolled their own. An address like $file->address+0xabcdef should be possible, but isn't in the distribution of 5.2. After the patch it is. i've filed the patch with an already open bug report on this on GNU gdb 5.2 Nick > > Greg > > > # diff -wu gdb-5.2/gdb/symfile.c~ gdb-5.2/gdb/symfile.c > > --- gdb-5.2/gdb/symfile.c~ Tue May 28 15:51:37 2002 > > +++ gdb-5.2/gdb/symfile.c Tue May 28 15:51:06 2002 > > @@ -1546,11 +1546,15 @@ > > char *val = sect_opts[i].value; > > char *sec = sect_opts[i].name; > > > > +#ifdef 0 > > val = sect_opts[i].value; > > if (val[0] == '0' && val[1] == 'x') > > addr = strtoul (val+2, NULL, 16); > > else > > addr = strtoul (val, NULL, 10); > > +#else > > + addr = parse_and_eval_address(val); > > +#endif > > > > /* Here we store the section offsets in the order they were > > entered on the command line. */ > > -- > See complete headers for address and phone numbers > -- n_hibma@van-laarhoven.org http://www.van-laarhoven.org/ n_hibma@FreeBSD.org http://www.etla.net/~n_hibma/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020529091727.G231-100000>