Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Feb 2020 17:03:01 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Fehmi Noyan ISI <fnoyanisi@yahoo.com>
Cc:        freebsd-hackers@freebsd.org
Subject:   Re: diff(1) -c and -u options
Message-ID:  <20200215160301.ebcr5allppzgbgri@ivaldir.net>
In-Reply-To: <83CB71EA-714E-4C91-9E2B-143A0E222D37@yahoo.com>
References:  <83CB71EA-714E-4C91-9E2B-143A0E222D37.ref@yahoo.com> <83CB71EA-714E-4C91-9E2B-143A0E222D37@yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--quupu7i3q4pq2nt2
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 15, 2020 at 06:38:03PM +1300, Fehmi Noyan ISI via freebsd-hacke=
rs wrote:
> Hi,
>=20
> I am working on same changes to diff(1) (bug 243975) and noticed that one=
 of the atf tests does this (in /usr/src/usr.bin/diff/tests/diff_test.sh un=
ified_body())
>=20
>    atf_check -o file:$(atf_get_srcdir)/unified_c9999.out -s eq:1 \
>        diff -u -c9999 -L input_c1.in -L input_c2.in "$(atf_get_srcdir)/in=
put_c1.in" "$(atf_get_srcdir)/input_c2.in=E2=80=9D
>=20
>=20
> when I try it out myself, -u -cNUM and -cNUM give the same output, making=
 -u redundant here.
> GNU diff complains about incompatible output styling when -u -c are passe=
d as arguments at the same time.
>=20
> I would assume -u -cNUM was used to limit the number of output lines but =
the same can be achieved by -uNUM anyway.
>=20
> I thought about removing this test case since it does not test anyting re=
lated to unified output (-u) (? here) but did not feel comfortable about it=
 and though it would be worthwhile to send an email to freebsd-hackers firs=
t.
>=20
> Any thoughts?

Sure go ahead, I am the author of the test suite there.

Feel free to ping me if you need.

Best regards,
Bapt

--quupu7i3q4pq2nt2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl5IFjMACgkQY4mL3PG3
Plq6+RAAwt+azMaoW/4qV/uXl4D36wvw9VUHlmrLjxuj8mUsD2tbYyX1pedeRgAN
5KXmPoknj+Ag8oQm6Apfsawmhcd7heAc7ZFoxUEpYKVdw88QkEgopiC/13usHMN5
DRprXyDKU2YJ4a2NW4aGIqyWDA5eE7MUNQs5amodJS3Q5IzZ3nDVcAuVIU1V76da
H3zy5wpitRDnbnR/5kLD6B4l3H2JbNSO0cepKg5sdutfA/47cDvMjpIcg25WjIeY
WTHHqZyDBPZgS/nLznbTgRpoiWRbA9bZQdWIhvoG7Mo/u9+PyEvyM2OmiNtJUqxB
PSeTjxjTcqA3aeRFdl5lE9srAJGBCYYfQjquO/Ye5xhNV1DhD8Bd6Q41Tmg531U3
hywCMnOy03k46PubnI0rHllyj8A3sm47iglEMEaYom9OU+EIHLYY3CGNdjbDSCXO
fD/wWuUHolD5m09V8leQzqZV0OaOpSgwRO6eQ88T7/PCLwtkRA7wBFWBRzA4giNa
2WOAStYy+N74bEw2Ov8J7JCiYxXAPprUO8ivlbQ2Xde+xWIil8fmN6BjemkWONYf
VQNMAaac08g3eBLENrftIPmYZnaXrRighUWNk5CoGcDliuYyxph1ffwZUNFW4gk7
2aPg0x1LfgJuN8f2bAwhpvr2bhBq4pJt/LLf++TudnrzwZeRyUA=
=iblR
-----END PGP SIGNATURE-----

--quupu7i3q4pq2nt2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200215160301.ebcr5allppzgbgri>