Date: Tue, 26 Jun 2018 22:40:00 +0800 (CST) From: kelly <kelly@rsw-power.com> To: freebsd-jail@freebsd.org Subject: Re: Handheld Inkjet Printer Manufacturer Message-ID: <123b8573.12e8c.16436342a0b.Coremail.kelly@rsw-power.com>
next in thread | raw e-mail | index | archive | help
RGVhciBNYW5hZ2VyLAoKCkdvb2QgZGF5IQoKCldlIGluZGVwZW5kZW50bHkgZGV2ZWxvcGVkIGEg aGFuZGhlbGQgaW5ramV0IHByaW50ZXIgd2l0aCBnb29kIHF1YWxpdHksIHdoaWNoIGlzIHdpZGVs eSB1c2VkIGFuZCBwb3B1bGFyIHRocm91Z2hvdXQgZGlmZmVyZW50IGNvdW50cmllcy4gSG9wZSB0 aGUgYmVsb3cgcHJvZHVjdCBjYW4gaGVscCB5b3Ugc2F2ZSB0aGUgY29zdHMuCgoKRm9sbG93aW5n IGlzIG9uZSBvZiBvdXIgbW9kZWw6Ckl0ZW06IEhhbmRoZWxkIElua2pldCBQcmludGVyIHdpdGgg U29sdmVudCBJbmsgKFF1aWNrIERyeSkKLSBXaXRoIDMuNSBpbmNoIHRvdWNoYWJsZSBzY3JlZW4g dGhhdCB5b3UgY2FuIGVkaXQgdGhlIGNvbnRlbnRzIGRpcmVjdGx5IHZpYSBzY3JlZW4gb3IgaW1w b3J0ZWQgdGhlIGNvbnRlbnRzIGZyb20gVS1kaXNrLgotIFBvcnRhYmxlLCBzaW1wbGUgaW50ZXJm YWNlIGFuZCBlYXN5IHRvIG9wZXJhdGUuCi0gSXQgY2FuIHByaW50IG9uIGRpZmZlcmVudCBraW5k cyBvZiBtYXRlcmlhbHMsIHN1Y2ggYXMgcGFwZXJzLCBjYXJ0b25zLCBwbGFzdGljcywgZ2xhc3Nl cywgd29vZHMsIHN0b25lcywgd2FsbHMsIHN0ZWVscyBwaXBlcywgbWV0YWxzLCBjYWJsZXMsIGZp bG0gbWF0ZXJpYWxzLCBldGMuCi0gSXQgY2FuIHByaW50IENoaW5lc2UsIEVuZ2xpc2ggbGV0dGVy cywgbnVtYmVycywgUVIgY29kZSwgc2NhbiBjb2RlLCBiYXJjb2RlLCBiYXRjaCBjb2RlLCBleHBp cnkgZGF0ZSwgdGltZSwgY291bnRlciwgc3ltYm9scywgbG9nbywgbWFya3MsIHNtYWxsIHBpY3R1 cmVzIGV0Yy4KLVdlIGhhdmUgbGFyZ2UgZGF0YSBzdG9yZSB1cCB0byAyMDAgbWVzc2FnZXMuCi1X ZSBoYXZlIGRpZmZlcmVudCBjb2xvcnMgaW5rOiBibGFjaywgcmVkLCBidWxlLHllbGxvdywgd2hp dGUgYW5kIGludmlzaWJsZSBVViBsaWdodCBpbmsuCiAgICAKQW55IGludGVyZXN0cyBwbGVhc2Ug Y29udGFjdCB1cyBmb3IgbW9yZSBpbmZvcm1hdGlvbi5XZSBjYW4gc2hvdyB5b3Ugb3VyIGJyb2No dXJlIGFuZCB2aWRlby4gU2FtcGxlIGFyZSBhdmFpbGFibGUsIHRvbyEKICAgICAgICAgICAgICAg ICAKVGhhbmtzIGFuZCBSZWdhcmRzLAotLQoKS2VsbHkgQ2hlbgpTYWxlcyBSZXByZXNlbnRhdGl2 ZQpTaGVuemhlbiBTd2Fyb25pa2kgVGVjaG5vbG9neSBDby4sIEx0ZC4gICAgICAgICAKTW9iaWxl ICYgV2hhdHNhcHA6ODYtMTMyNjY2ODU2NjkKU2t5cGU6IGtlbGx5XzMxNjcKV2ViOnd3dy5iZXNo ZW5ncHJpbnRlcnMuY29t From owner-freebsd-jail@freebsd.org Tue Jun 26 18:43:08 2018 Return-Path: <owner-freebsd-jail@freebsd.org> Delivered-To: freebsd-jail@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6623A1010F1C; Tue, 26 Jun 2018 18:43:08 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org (gritton.org [199.192.165.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gritton.org", Issuer "Let's Encrypt Authority X3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 05BBA7DD09; Tue, 26 Jun 2018 18:43:07 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org ([127.0.0.131]) by gritton.org (8.15.2/8.15.2) with ESMTP id w5QIgqIK007004; Tue, 26 Jun 2018 12:42:52 -0600 (MDT) (envelope-from jamie@freebsd.org) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Jun 2018 12:42:52 -0600 From: James Gritton <jamie@freebsd.org> To: Eitan Adler <lists@eitanadler.com> Cc: bsd-lists@bsdforge.com, freebsd-jail@freebsd.org, freebsd-stable Stable <freebsd-stable@freebsd.org> Subject: Re: jail related inconsistencies in FreeBSD tools parameters In-Reply-To: <CAF6rxgkdtZ81mWQty6KjqUiAH-p6=fNXfm4g03EL4V+00Q3KAg@mail.gmail.com> References: <6dd9952452c73826a2f9c01612586bea@udns.ultimatedns.net> <d2068437-672c-5472-0480-86fd094a8143@quip.cz> <18000a3b93085c91aeffbca937862786@freebsd.org> <CAF6rxgmpRTiqd5yA6C9crjz8M-gJXWcS2Q1bCSjQpZS45QRRfA@mail.gmail.com> <51718e96f63175e997cb8268381d1070@freebsd.org> <CAF6rxgkdtZ81mWQty6KjqUiAH-p6=fNXfm4g03EL4V+00Q3KAg@mail.gmail.com> Message-ID: <8b11953ce292aff0bc60298e2e7613d6@freebsd.org> X-Sender: jamie@freebsd.org User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" <freebsd-jail.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-jail>, <mailto:freebsd-jail-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-jail/>; List-Post: <mailto:freebsd-jail@freebsd.org> List-Help: <mailto:freebsd-jail-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-jail>, <mailto:freebsd-jail-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 26 Jun 2018 18:43:08 -0000 On 2018-06-23 12:58, Eitan Adler wrote: > On 23 June 2018 at 08:50, James Gritton <jamie@freebsd.org> wrote: >> On 2018-06-23 09:45, Eitan Adler wrote: >>> >>> On 23 June 2018 at 08:30, James Gritton <jamie@freebsd.org> wrote: >>>> >>>> On 2018-06-22 16:03, Miroslav Lachman wrote: >>>>> >>>>> >>>>> Chris H wrote on 2018/06/22 23:46: >>>>>> >>>>>> >>>>>> On Fri, 22 Jun 2018 23:13:17 +0200 "Miroslav Lachman" >>>>>> <000.fbsd@quip.cz> >>>>>> said >>>>>> >>>>>>> I don't know if it is better to discuss it in jail@ or stable@ >>>>>>> list so >>>>>>> a >>>>>>> do cross-post. >>>>>>> >>>>>>> FreeBSD has many jail aware utilities but they are inconsistent >>>>>>> in >>>>>>> taking JID as parameter. >>>>>>> >>>>>>> For example "sockstat" takes -j JID "Show only sockets belonging >>>>>>> to >>>>>>> the >>>>>>> specified jail ID" and it means numeric ID only. >>>>>>> On the other hand "ps" takes -J JID "This may be either the jid >>>>>>> or >>>>>>> name >>>>>>> of the jail. Use -J 0 to display only host processes." >>>>>>> The same apply for "top", it understands jid as a number or name >>>>>>> of >>>>>>> the >>>>>>> jail too. >>>>>>> Then again "cpuset" takes only numerical ID of the jail... >>>>>>> >>>>>>> Shouldn't it be consistent across all FreeBSD base utilities so >>>>>>> all of >>>>>>> them can use numerical ID and name? >>>>>> >>>>>> >>>>>> Good idea! Are you offering to create a patch? ;-) >>>>>> It'd be my guess that given they weren't all created at the same >>>>>> time, >>>>>> nor >>>>>> the same individual; that (quite probably?) the "jail" additions >>>>>> were >>>>>> also >>>>>> added at different times, and by different people. So I'd imagine >>>>>> that >>>>>> unless someone with a commit bit decides one day they'd like to >>>>>> take >>>>>> that >>>>>> on. Someone(tm) maybe you? will need to propose a patch. :-) >>>>> >>>>> >>>>> >>>>> If I can understand C sources I will create the patch by myself >>>>> instead of just posting here. Unfortunately I am able to code in >>>>> sh, >>>>> php and a bit of javascript and perl but no C. :) >>>>> >>>>> Miroslav Lachman >>>> >>>> >>>> >>>> Sure, a PR would be handy for this - it's a pretty simple thing to >>>> add, >>>> and >>>> consistency would indeed be a good move. >>> >>> >>> Agreed. I'll review and commit such patches. I'd like to see a single >>> function for taking a "id or name". Ideally it would live in a >>> library, perhaps libjail? >> >> >> It already lives there: jail_getid(3) > > I was thinking of a more generic one that does id or name. Now that I > think about it a bit more, C makes this kind of thing impossible to do > usefully. > > That said, I'll still review and commit any patches to existing tools > to make them behave consistently. Yes, jail_getid(3) works with either a numeric ID or a name. I've added a patch to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229266 for the four programs I've found that need help. I've tested the easy ones (cpuset and sockstat). - Jamie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?123b8573.12e8c.16436342a0b.Coremail.kelly>