Date: Fri, 4 Sep 2020 14:03:30 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: "Tobias C. Berner" <tcberner@gmail.com> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r547476 - head/astro/libkgeomap Message-ID: <20200904120330.GA14483@PinebookPro> In-Reply-To: <CAOshKtdbWmAmannRo-d6=fyMT8b%2BUAeiCuV85iTW7_za6MhFSg@mail.gmail.com> References: <202009031930.083JUJea043912@repo.freebsd.org> <CAOshKtdbWmAmannRo-d6=fyMT8b%2BUAeiCuV85iTW7_za6MhFSg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--17pEHd4RhPHOinZp Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Hello, I'm not actually sure and if there's any feature that needs webengine to work, I didn't want to break it. I think it will be ok to drop webengine, but I'm not the maintainer and dropping it would require maintainer approval, so what I did was quicker :) On 20-09-03 21:39:16, Tobias C. Berner wrote: >Moin moin > >Looking at this change, is webengine actually required? >We could also probably get rid of this port, digikam, the only >consumer, should not require it anymore, afaik. > > >mfg Tobias > >On Thu, 3 Sep 2020 at 21:30, Piotr Kubaj <pkubaj@freebsd.org> wrote: >> >> Author: pkubaj >> Date: Thu Sep 3 19:30:18 2020 >> New Revision: 547476 >> URL: https://svnweb.freebsd.org/changeset/ports/547476 >> >> Log: >> astro/libkgeomap: disable webengine on non-x86 >> >> Use the same hack that astro/marble uses. >> >> Modified: >> head/astro/libkgeomap/Makefile >> >> Modified: head/astro/libkgeomap/Makefile >> ============================================================================== >> --- head/astro/libkgeomap/Makefile Thu Sep 3 18:55:45 2020 (r547475) >> +++ head/astro/libkgeomap/Makefile Thu Sep 3 19:30:18 2020 (r547476) >> @@ -19,11 +19,16 @@ USES= cmake compiler:c++11-lang gettext kde:5 pkgconf >> qt:5 tar:xz >> USE_KDE= config coreaddons ecm i18n kio marble service textwidgets >> USE_QT= concurrent core dbus declarative gui location network \ >> - printsupport webchannel webengine webkit widgets xml \ >> + printsupport webchannel webkit widgets xml \ >> buildtools_build qmake_build >> >> USE_LDCONFIG= yes >> >> -OPTIONS_DEFINE= DOCS >> +OPTIONS_DEFINE= DOCS WEBENGINE >> +OPTIONS_DEFAULT_amd64= WEBENGINE >> +OPTIONS_DEFAULT_i386= WEBENGINE >> + >> +WEBENGINE_DESC= Add dependency on qt5-webengine >> +WEBENGINE_USE= QT=webengine >> >> .include <bsd.port.mk> --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl9SLQ0wFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydWSAP/A37LcMRWY2Qkj2nTw2IiVFgq0xwlOOwYH+Q9sCvwNLMQQAW7MNdHUfu mLZf4pc5o5l/HRT3Q1GS3Fes0sVHUKpQCfNwWoS7C6xUm6KI6WZ+uEj0m/tA04ai 8ClCjZjkIltM9ceQH4TWSAMGYnlgffxpEPxbBAUHX/7OAHLQ+MnOxQULBLZsOPk4 xFSVvvfUr4/yg+p7x0iStnCrkYjqPGXZp+IkaqaOswAq489q51Ws/mX0We94mVrM QkBvkRu1d8mpnT7u3VSPJrx/4wVMDHfmj+pDUvBpTzOHlONZJ6OPwSo86+nk64Om y5KvnIkB0gWiuHo+L3kAxbi43V5pffEVYP0efjuuajtKBwbKQD+05+ehsJL3+CAC yEM3ks1V1DYlVGctL0TpjAAIa9FxXiQL598LDkSViX7X5xf0sNHhbrgrqwN3y8ZO eHFxUr9KSs1yWtXBMcXIbqzeAQq4ReJPJuHe7B8pJmrcxIckcU1jZxsX1MX/JGaF z+UFoQwsL2LXskwoHdFv0ozL5BU0wYxGVMxBvFtE8ZMhUYlZaI8PNwAV1mwAteg3 hqQ7HZRTmsCxvhMkm3Vk//58R2NkO6HwCgE41jyrjKs3aFf+oilgV4R8iw8fkIDS dLPVKLu481YskKNwSuSAph0B//CybuX1J+sLI01VaRp2cQVQuLim =tNiy -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200904120330.GA14483>