From owner-cvs-ports@FreeBSD.ORG Wed Oct 14 04:54:13 2009 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A60A1065676 for ; Wed, 14 Oct 2009 04:54:13 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A95BF8FC1C for ; Wed, 14 Oct 2009 04:54:12 +0000 (UTC) Received: (qmail 7061 invoked by uid 399); 14 Oct 2009 04:54:11 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Oct 2009 04:54:11 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD55971.3080506@FreeBSD.org> Date: Tue, 13 Oct 2009 21:54:09 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200910131851.n9DIpB7P057665@repoman.freebsd.org> <4AD4DE92.3090808@FreeBSD.org> <86iqeietvu.fsf@ds4.des.no> <4AD551E2.3010407@FreeBSD.org> <86tyy2d1si.fsf@ds4.des.no> In-Reply-To: <86tyy2d1si.fsf@ds4.des.no> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/varnish Makefile ports/www/varnish/files pkg-message.in varnishd.in varnishlog.in varnishncsa.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 04:54:13 -0000 Dag-Erling Smørgrav wrote: > Doug Barton writes: >> Dag-Erling Smørgrav writes: >>> When does pre_start run? >> um, before start? :) After load_rc_config is what I think you're >> getting at. It's run as part of run_rc_command. >>> Does your patch allow the user to override varnishd_flags? >> Good point. I added that to the attached version. > > That's a lot of extra code for no percievable benefit... The if/else code is essentially the same as yours. Splitting out the flags that are common between your two options makes the code more readable. There is also the issue that code in rc.d scripts shouldn't run unconditionally, but I don't regard that as critical in this case since you're just setting variables. Ultimately it's up to you whether you want to accept the patches or not. I think they're useful but I am not going to make a stink about it. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/