From owner-svn-src-all@FreeBSD.ORG  Fri Jun 20 17:35:21 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 03FEE749;
 Fri, 20 Jun 2014 17:35:21 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D0328283B;
 Fri, 20 Jun 2014 17:35:20 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 568A6B923;
 Fri, 20 Jun 2014 13:35:19 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Kabaev <kan@freebsd.org>
Subject: Re: svn commit: r267660 - head/sys/dev/firewire
Date: Fri, 20 Jun 2014 11:33:38 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; )
References: <201406200145.s5K1j3TC083304@svn.freebsd.org>
In-Reply-To: <201406200145.s5K1j3TC083304@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201406201133.38671.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 20 Jun 2014 13:35:19 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jun 2014 17:35:21 -0000

On Thursday, June 19, 2014 9:45:03 pm Alexander Kabaev wrote:
> Author: kan
> Date: Fri Jun 20 01:45:03 2014
> New Revision: 267660
> URL: http://svnweb.freebsd.org/changeset/base/267660
> 
> Log:
>   Set target->sbp field to valid value when sbp device is created.
>   
>   The sbp_cam_detach_target can be called from sbp_post_explore function
>   on the first target that is not really attached and it was written with
>   the corresponding safety check in place to tolerate that. Unfortunately
>   the recent locking cleanup did add a locking assertion that tries to
>   dereference the target->sbp pointer unconditionally, which causes less
>   than desirable outcome. Since the assertion is useful, just initialize
>   the target sbp pointer once when sbp device is being initialized instead
>   of when the target is being attached. This makes assertion work in all
>   cases and fixes the crash on boot.

Thanks.

-- 
John Baldwin