From owner-svn-src-stable@freebsd.org Sat Nov 17 23:51:50 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD149110AC16; Sat, 17 Nov 2018 23:51:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x133.google.com (mail-it1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 237F386140; Sat, 17 Nov 2018 23:51:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x133.google.com with SMTP id a205-v6so3239354itd.4; Sat, 17 Nov 2018 15:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rep41SMUOAI//UDfl1N8mWxNnuCFzoAA/4TjfiINLZY=; b=CwZz796DRhP1WBF6YCCBe4JZGiKiCyC4RpW+XMFswN3xwbHkyctcllnKP4x4cAxmFD ZdHC79A2/+gqyGy5xCCCjqxYbdNt0jVYTxgpbFNrgTAWZyB9PzqlUZLZzLABY7ZBDR1G 9zy8TDXyR23bYSfq4VaXOO/KoqMy4KZav/KKv0tB21TeHp0+PyMQaFkg+9jQSM7Y9El0 3e6hf6l8KAUL9efLcei5umjuYTTusk2OllbsfK11zH5KMrCn40/HG2YA/mTKQCI0CbtS M3omPws66HL8seMZqA/UjYVNPdB79We4bQ18QDJqyHtXIaSdZL542T3NsTy0nGxXiMt2 3mSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=rep41SMUOAI//UDfl1N8mWxNnuCFzoAA/4TjfiINLZY=; b=PBL49aI5U3WHxol5ejFITWrmZbxpIKigzKLqkxhUb+BfNAT5ssJRkBEez9zjDGy/47 5cu6MIlx3eVobtbRvdYI9mbHjPkW/EwDPoBIlI26sKtB0qvIv6GyNU6WI8U1FiLKrcOs DsQqDLb3778CG3ApnJ0tg3OufnL4L9L8cdfKY+E7fm6ZyYyDpsjxbwMn+lDLnL9pGZry iDTlZ8tKPxQugDTwcUVf77/jSWoOxRSN55ZJy5obBrY7/BrtzWO0w4PIbvUS+F2UVuKE XwantKPA0ODsspsitG8JS7EyirkfrEPwp3TvxlGC5AdxuHQdmoBlDpZXBRML2IiJoQ8e dlvw== X-Gm-Message-State: AGRZ1gL5JzdRTIjufnPbUl5z/zEIDeli8ygvWTelnf0Y/ca2CYALV0LQ 9yww53fBAGDCcWhaUgQpzBisEDKaQp8= X-Google-Smtp-Source: AJdET5dBKDzn58XY+N8rZw9OO5JTB005oheh05hel1kG77/jIRTh6x/uusHJMzHYxFsKrbB+E25UzQ== X-Received: by 2002:a02:8a1c:: with SMTP id j28mr5397679jak.49.1542498709279; Sat, 17 Nov 2018 15:51:49 -0800 (PST) Received: from raichu (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id c187-v6sm11769666itc.2.2018.11.17.15.51.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Nov 2018 15:51:48 -0800 (PST) Sender: Mark Johnston Date: Sat, 17 Nov 2018 18:51:44 -0500 From: Mark Johnston To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r340511 - stable/12/sys/kern Message-ID: <20181117235144.GA2799@raichu> References: <201811172001.wAHK1aR7047919@repo.freebsd.org> <201811172347.wAHNlGi6053535@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201811172347.wAHNlGi6053535@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 237F386140 X-Spamd-Result: default: False [-3.30 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[3.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.94)[-0.935,0]; IP_SCORE(-2.65)[ip: (-8.77), ipnet: 2607:f8b0::/32(-2.61), asn: 15169(-1.77), country: US(-0.10)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2018 23:51:51 -0000 On Sat, Nov 17, 2018 at 03:47:16PM -0800, Rodney W. Grimes wrote: > > Author: markj > > Date: Sat Nov 17 20:01:35 2018 > > New Revision: 340511 > > URL: https://svnweb.freebsd.org/changeset/base/340511 > > > > Log: > > MFC r339731: > > Add FALLTHROUGH comments to appease Coverity. > > > > Modified: > > stable/12/sys/kern/kern_environment.c > > stable/12/sys/kern/vfs_mount.c > > Directory Properties: > > stable/12/ (props changed) > > > > Modified: stable/12/sys/kern/kern_environment.c > > ============================================================================== > > --- stable/12/sys/kern/kern_environment.c Sat Nov 17 20:00:10 2018 (r340510) > > +++ stable/12/sys/kern/kern_environment.c Sat Nov 17 20:01:35 2018 (r340511) > > @@ -839,10 +839,13 @@ getenv_quad(const char *name, quad_t *data) > > switch (vtp[0]) { > > case 't': case 'T': > > iv *= 1024; > > + /* FALLTHROUGH */ > > case 'g': case 'G': > > iv *= 1024; > > + /* FALLTHROUGH */ > > case 'm': case 'M': > > iv *= 1024; > > + /* FALLTHROUGH */ > > case 'k': case 'K': > > iv *= 1024; > Missing /* FALLTHROUGH */ ?? The statement following "case '\0':" is a break. > > > case '\0': > > And a refactor: > > case 't': case 'T': > case 'g': case 'G': > case 'm': case 'M': > case 'k': case 'K': > iv *= 1024; > /* FALLTHROUGH */ > case '\0': > > Isnt that the same functionality? No, it isn't.