From owner-svn-src-projects@freebsd.org  Thu Aug 13 06:29:11 2015
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB02D9A08A1
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 13 Aug 2015 06:29:11 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com
 [IPv6:2607:f8b0:4001:c05::234])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A59F1FB7;
 Thu, 13 Aug 2015 06:29:11 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: by igbpg9 with SMTP id pg9so29549000igb.0;
 Wed, 12 Aug 2015 23:29:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=eXI+LJrV0eXzk6mqcZAK/ftliRHVHhGMFfSqSpBlxeI=;
 b=GqxIvu/YRDjn5pu1bxYTJZVY+ZVAirYRihxaHJYnLSgbe3pFNmKEs92zNCNtrP+nFy
 HVNGzFkPBNbAAPvX0dp6SviMIMbhSWObzxsvpim3m5eeKUtSbHAyCMZmH8U58/ol3OcW
 k0fNtVcLJsXozKKPYoi0lcCkfOfoyCd2l3DAG1+CcQgbwFuv/608+0785fzLoYgWb1Eb
 nSPFWkMsZQbrrnuNhVOTEmgggCpXDyTHulwPS1a3hB/onfq7W27d+F/wVTZsUpuMoKyd
 MLvYshYI0YRVtBF3oI4WwXpaLP8+q7vPzncFcTSL9CW62PZBRv+4ijtbci+2SK1S0ptt
 5zpg==
MIME-Version: 1.0
X-Received: by 10.50.43.227 with SMTP id z3mr26110457igl.22.1439447350362;
 Wed, 12 Aug 2015 23:29:10 -0700 (PDT)
Received: by 10.36.38.133 with HTTP; Wed, 12 Aug 2015 23:29:10 -0700 (PDT)
In-Reply-To: <20150813061802.GA62875@ivaldir.etoilebsd.net>
References: <201508082257.t78MvIT1000841@repo.freebsd.org>
 <CACYV=-GnOpPddd-x_J0yW4g4QFsdcEVXaVc9CER9JD7iObGzAg@mail.gmail.com>
 <20150812182739.GB51754@ivaldir.etoilebsd.net>
 <55CB91FD.8000004@fastmail.net>
 <20150813114425.X996@besplex.bde.org>
 <20150813061802.GA62875@ivaldir.etoilebsd.net>
Date: Wed, 12 Aug 2015 23:29:10 -0700
Message-ID: <CAJ-VmontEjFwcxH6uVGxAk_exxNBj4PbtFE03A8-qP=Jux2V4Q@mail.gmail.com>
Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef
From: Adrian Chadd <adrian.chadd@gmail.com>
To: Baptiste Daroussin <bapt@freebsd.org>
Cc: Bruce Evans <brde@optusnet.com.au>, Bruce Simpson <bms@fastmail.net>, 
 Davide Italiano <davide@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 svn-src-projects@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2015 06:29:11 -0000

[snip]

You know, at the point where you're iterating over a tree to get its
membership count, you may as well just have stored the count in the
top-level owner struct..

(This is how O(wtf) style mistakes sneak up on you and make people
like me cry in the future.. :( )


-adrian