Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Oct 2017 14:28:57 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r324954 - head/sys/netinet
Message-ID:  <201710241428.v9OESvkm089829@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Tue Oct 24 14:28:56 2017
New Revision: 324954
URL: https://svnweb.freebsd.org/changeset/base/324954

Log:
  Fix a locking issue found by running AFL on the userland stack.
  Thanks to Felix Weinrank for reporting the issue.
  
  MFC after:	3 days

Modified:
  head/sys/netinet/sctp_input.c

Modified: head/sys/netinet/sctp_input.c
==============================================================================
--- head/sys/netinet/sctp_input.c	Tue Oct 24 12:56:08 2017	(r324953)
+++ head/sys/netinet/sctp_input.c	Tue Oct 24 14:28:56 2017	(r324954)
@@ -4863,9 +4863,6 @@ process_control_chunks:
 				if ((stcb != NULL) && (stcb->asoc.total_output_queue_size)) {
 					;
 				} else {
-					if (stcb != NULL) {
-						SCTP_TCB_UNLOCK(stcb);
-					}
 					*offset = length;
 					if (stcb != NULL) {
 #if defined(__APPLE__) || defined(SCTP_SO_LOCK_TESTING)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710241428.v9OESvkm089829>