From owner-freebsd-arch Tue Oct 23 9:49:11 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id 6B53037B401 for ; Tue, 23 Oct 2001 09:49:08 -0700 (PDT) Received: (qmail 90197 invoked from network); 23 Oct 2001 16:49:05 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 23 Oct 2001 16:49:05 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200110230657.f9N6ve716142@harmony.village.org> Date: Tue, 23 Oct 2001 09:48:58 -0700 (PDT) From: John Baldwin To: Warner Losh Subject: Re: Style Wars Cc: arch@FreeBSD.ORG, Peter Wemm , Jonathan Lemon , Julian Elischer Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-Oct-01 Warner Losh wrote: > In message <3BD5100A.2D09B278@elischer.org> Julian Elischer writes: >: When declaring variables in structures, declare them sorted by use, >: then >: by size, and then by alphabetical order. The first category normally >: doesn't apply, but there are exceptions. Try to make the structure >: readable by aligning the variable names using either one or two tabs >: depending upon your judgement. Names following extremely long types >: should be separated by a simple space. i.e. use int^I^Ix; and >: struct foo^I*x; and struct verylongtypename *bar; >: >: >: This approximates 1b). >: >: If I don't hear a large outcry (it was a loud 'yes' last time but I didn't >: see an agreement that it should be done) then I'd like to make that change. > > That was the approximate consensus that we had. I think as such, it > should be committed w/o revisting the discussion :-) Agreed. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message