From owner-svn-src-all@freebsd.org Sat Aug 4 22:49:02 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6A2010564AD; Sat, 4 Aug 2018 22:49:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 66AAA8CB72; Sat, 4 Aug 2018 22:49:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f43.google.com with SMTP id h20-v6so13386707itf.2; Sat, 04 Aug 2018 15:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=9F2AzxyBj14X0ymAfTLXJoCeSDYQtZsV9nz48ogeS3M=; b=cXMaZlUjyAEt4uPni4rf24yR0iEnUyz8thoNJ5jzuc6xz3ubk+ns7zlfFttfY/QRhR NOkV1psI5F+MmnRY6YPykmb+NcFONsrLWrNNTUX1Wgut8eYiUS2qymkTgGZaIRNgldVm torYILfmbuoLqRnTp/uAoIjb4BGcgqJc21YCeD4ZMNFWG7rxyeIdvnY363KyKA8Wv5sh MoyBfVr4xCSHG/58gnwlPy2mc2NpeVOWD0t2N2E0VgaDPTNi8s0Y7+XucaIvaYPWkZCQ qDa6BVZWFCzt4Kl9q9tOQmFutJEC6HigJm32iIzjXNaDM8GN6RZfyBg/PxYDZCDbRkP3 Z3wQ== X-Gm-Message-State: AOUpUlHtznigwNlB1GUVwwODDOY81URPHX5xYu8cozBe+YLKv31XBmQZ n6UqDQuECoQCfWx6dTMFY5bILjiG X-Google-Smtp-Source: AAOMgpcxbGVrymV1RTrpGl7JSXGmXKKWiqyv/Wf4iVKZGhXtlsBlHfZpX/WdTFZztVMGVjrwXNJiBA== X-Received: by 2002:a02:45cd:: with SMTP id o74-v6mr7760552jad.43.1533422936187; Sat, 04 Aug 2018 15:48:56 -0700 (PDT) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com. [209.85.223.175]) by smtp.gmail.com with ESMTPSA id x73-v6sm1678653ita.30.2018.08.04.15.48.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Aug 2018 15:48:55 -0700 (PDT) Received: by mail-io0-f175.google.com with SMTP id z20-v6so8041427iol.0; Sat, 04 Aug 2018 15:48:55 -0700 (PDT) X-Received: by 2002:a6b:be46:: with SMTP id o67-v6mr10320298iof.143.1533422935800; Sat, 04 Aug 2018 15:48:55 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:7e0a:0:0:0:0:0 with HTTP; Sat, 4 Aug 2018 15:48:55 -0700 (PDT) In-Reply-To: References: <201808042208.w74M8OmD057603@repo.freebsd.org> From: Conrad Meyer Date: Sat, 4 Aug 2018 15:48:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337334 - head/lib/libc/sys To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 22:49:03 -0000 If not stale, it was inaccurate as-is. It seems to be used by a bunch of different clock-related drivers and routines, e.g., $ rg '(tz_minuteswest|tz_dst|utc_offset)' | wc -l 36 To me there is a disconnect between that use and "timezone is no longer used; this information is kept outside the kernel." If you or someone else wants to reword the "unused" note in a more nuanced fashion, I'm definitely supportive of that. (Or remove the kernel uses aside from pass-thru for gettimeofday and restore the original note, of course.) I was actually going to deorbit the date(1) -t/-d options on the basis of the settimeofday manual page note until I did the due diligence to verify it was actually unused, and discovered that not to be true. All the best, Conrad On Sat, Aug 4, 2018 at 3:15 PM, Warner Losh wrote: > How is this stale? It said it unused, and now it doesn't say this are is > completely ignored. > > Warner > > On Sat, Aug 4, 2018, 11:08 PM Conrad Meyer wrote: >> >> Author: cem >> Date: Sat Aug 4 22:08:24 2018 >> New Revision: 337334 >> URL: https://svnweb.freebsd.org/changeset/base/337334 >> >> Log: >> settimeofday(2): Remove stale note about timezone >> >> Contrary to the removed comment, the kernel does appear to use the >> timezone >> argument of settimeofday. The comment dates to the BSD4.4 import; I >> assume it >> is just stale. >> >> Modified: >> head/lib/libc/sys/gettimeofday.2 >> >> Modified: head/lib/libc/sys/gettimeofday.2 >> >> ============================================================================== >> --- head/lib/libc/sys/gettimeofday.2 Sat Aug 4 21:57:17 2018 >> (r337333) >> +++ head/lib/libc/sys/gettimeofday.2 Sat Aug 4 22:08:24 2018 >> (r337334) >> @@ -28,7 +28,7 @@ >> .\" @(#)gettimeofday.2 8.2 (Berkeley) 5/26/95 >> .\" $FreeBSD$ >> .\" >> -.Dd December 27, 2015 >> +.Dd August 4, 2018 >> .Dt GETTIMEOFDAY 2 >> .Os >> .Sh NAME >> @@ -44,11 +44,6 @@ >> .Ft int >> .Fn settimeofday "const struct timeval *tp" "const struct timezone *tzp" >> .Sh DESCRIPTION >> -.Bf -symbolic >> -Note: timezone is no longer used; this information is kept outside >> -the kernel. >> -.Ef >> -.Pp >> The system's notion of the current Greenwich time and the current time >> zone is obtained with the >> .Fn gettimeofday >> >