From owner-svn-src-head@freebsd.org Wed Apr 8 18:28:32 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 676C9278BA5; Wed, 8 Apr 2020 18:28:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48yCTC1DN1z4V3m; Wed, 8 Apr 2020 18:28:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x631.google.com with SMTP id t4so2801678plq.12; Wed, 08 Apr 2020 11:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J4/tz0kv53J6oGl6EElT+9Y7hSUYXd79bMJW+6Wwtvg=; b=YkZ+hI7V8PVwLAdO9oKjitH0CnnRpqU7zP/RN4ZblWzzG6HrpQO2UW7isFKJQP/7Ni C+ZLNzu1vfq+7QOKYEx1wYw53690lhTSORiyQubOLUJvz+Igb18y6l5MKS4+/TQ5Kghs P7YWdxvF5WM5n4bELfRpBsmT1ba0r4qNIHxMNoelzLJ7xPN8xazstIdbpqK84Vej6iZE 7bX11FwZg2+/vWQiYwIWuuiRlzmrdnpKxlkJJzhP8JUydVPJoO8JRWCPif1z+VVvsb44 xoKqfZ9tEcaeWBPob634ciEGUQ4VikaKRSlvDVZWk65nkh1Xi0k2t8if3+CcP9qoTvhu 3kWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J4/tz0kv53J6oGl6EElT+9Y7hSUYXd79bMJW+6Wwtvg=; b=sbk0jtbc8uGC1c7IC5JTXSnmTPQ+kr2PiKVNhCeQzRsLoipxXA4EU/fVAJIwG5X9Ec sLczRX+8a3V5/PP25AAhMzRJzX5eDkfwHjDP9I/u1KhXJeyBXSTeq6tPPCf6ep/M3kuk /M1sHAKYt5cvi53dbbqoQxj2kJed9dRFKcsYYMsdEP/LWHyZbRW0g7gr7UbUkTL1WCla tV/pMg0/qGGFsnKUX8xbjYzJbcnG+q9gMHah43Bk7IVAg4U9BdZ26hm4vcGsmU0mrM4v tvXEfuVSXWGLjPW18Eh2VWdCZ5/Xb9SAafrzQyeyKMr7eImjG4tZLySBCTtfVoFjGEgG vmwQ== X-Gm-Message-State: AGi0PuZY37NzmD/OR3eFIknYT8cYq4ZWb697TiRBaSJa/gN/Qg+fv/Yq mTdxy2dJC83/mgW11C/JP7nFTuRXF/0= X-Google-Smtp-Source: APiQypJi8VzlhqkOoCZvHqrA7M55AIMLUZHDkkKnVqKgW24zFtyJ+4bGP3QKuXHRuYAjv/3Ut8i2Zg== X-Received: by 2002:a17:902:8305:: with SMTP id bd5mr8024197plb.114.1586370509095; Wed, 08 Apr 2020 11:28:29 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a2sm192845pja.44.2020.04.08.11.28.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2020 11:28:28 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: svn commit: r359689 - head/usr.sbin/config From: Enji Cooper In-Reply-To: <202004071414.037EEx5Q057793@repo.freebsd.org> Date: Wed, 8 Apr 2020 11:28:27 -0700 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <8AAE567D-BEC5-4AF1-B290-D4EA833ED96A@gmail.com> References: <202004071414.037EEx5Q057793@repo.freebsd.org> To: Kyle Evans X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Rspamd-Queue-Id: 48yCTC1DN1z4V3m X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=YkZ+hI7V; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::631 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RECEIVED_SPAMHAUS_PBL(0.00)[228.52.19.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-8.96), ipnet: 2607:f8b0::/32(-0.33), asn: 15169(-0.43), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 18:28:32 -0000 > On Apr 7, 2020, at 7:14 AM, Kyle Evans wrote: >=20 > Author: kevans > Date: Tue Apr 7 14:14:59 2020 > New Revision: 359689 > URL: https://svnweb.freebsd.org/changeset/base/359689 >=20 > Log: > config(8): "fix" a couple of buffer overflows >=20 > Recently added/changed lines in various kernel configs have caused = some > buffer overflows that went undetected. These were detected with a = config > built using -fno-common as these line buffers smashed one of our = arrays, > then further triaged with ASAN. >=20 > Double the sizes; this is really not a great fix, but addresses the > immediate need until someone rewrites config. While here, add some = bounds > checking so that we don't need to detect this by random bus errors or = other > weird failures. Good catch! This seems like it deserves a follow up PR in = Bugzilla. Cheers, -Enji=