From owner-svn-src-head@freebsd.org Sun Feb 26 09:29:39 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2C33CEB815; Sun, 26 Feb 2017 09:29:39 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D77C2982; Sun, 26 Feb 2017 09:29:37 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 0110225f; Sun, 26 Feb 2017 10:22:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=yuuZp3K0avPFn/YKsKwvIxXslGs=; b=n8S8jcW058h5RERNqKmEwAEWONOv dcdJ8kg4tcQuR5TcpVBSCTlZYcQ+RfFNZDePJXi/N4LUeTteUwOOcPYUo+6HoUA2 pnAq2qwUaR+BVaQRIdr2NpDjnX36CojH6qzRs3yqM7XhRr/mzLPoEJhJSHpWQI0K 7Wg595gF7l1Pu3E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=Vz9x9j165RvZngCvXGUDsFYb3pML5QMLuAFq50zomM6h1D+L0XP/aYgM DNPWiiY7IIGf9mozNg4uhPTezp1ZD1XdkjaiiGno61BqanviPfMz4/kFkrw5tpra Hbo9WVDibLzHn9YEVOjTJHwC2O9xhu5rwRELT/HZlCGbM0NvMjo= Received: from knuckles.blih.net (ip-54.net-82-216-203.roubaix.rev.numericable.fr [82.216.203.54]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 2fd6bb2c TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sun, 26 Feb 2017 10:22:55 +0100 (CET) Date: Sun, 26 Feb 2017 10:22:52 +0100 From: Emmanuel Vadot To: Ruslan Bukin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314212 - head/sys/dev/uart Message-Id: <20170226102252.a71cba36fd86822065e61b1d@bidouilliste.com> In-Reply-To: <201702241637.v1OGbZ1e047175@repo.freebsd.org> References: <201702241637.v1OGbZ1e047175@repo.freebsd.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.29; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 09:29:40 -0000 Hello, This break uart in ARM. Based on the comment of the macros since we're using our own device the ealier code was correct. Cheers, On Fri, 24 Feb 2017 16:37:35 +0000 (UTC) Ruslan Bukin wrote: > Author: br > Date: Fri Feb 24 16:37:35 2017 > New Revision: 314212 > URL: https://svnweb.freebsd.org/changeset/base/314212 > > Log: > Use correct macro for Synopsys UART driver declaration. > > Modified: > head/sys/dev/uart/uart_dev_snps.c > > Modified: head/sys/dev/uart/uart_dev_snps.c > ============================================================================== > --- head/sys/dev/uart/uart_dev_snps.c Fri Feb 24 16:11:55 2017 (r314211) > +++ head/sys/dev/uart/uart_dev_snps.c Fri Feb 24 16:37:35 2017 (r314212) > @@ -104,7 +104,7 @@ static struct ofw_compat_data compat_dat > { "snps,dw-apb-uart", (uintptr_t)&uart_snps_class }, > { NULL, (uintptr_t)NULL } > }; > -UART_FDT_CLASS(compat_data); > +UART_FDT_CLASS_AND_DEVICE(compat_data); > > #ifdef EXT_RESOURCES > static int -- Emmanuel Vadot