From owner-freebsd-ports@FreeBSD.ORG  Fri Jun  5 23:15:42 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 17BD010656BC
	for <freebsd-ports@freebsd.org>; Fri,  5 Jun 2009 23:15:42 +0000 (UTC)
	(envelope-from vmagerya@gmail.com)
Received: from mail-bw0-f214.google.com (mail-bw0-f214.google.com
	[209.85.218.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 903BA8FC1C
	for <freebsd-ports@freebsd.org>; Fri,  5 Jun 2009 23:15:41 +0000 (UTC)
	(envelope-from vmagerya@gmail.com)
Received: by bwz10 with SMTP id 10so23935bwz.43
	for <freebsd-ports@freebsd.org>; Fri, 05 Jun 2009 16:15:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=C2S8cjTNvteyzkUhVbX/x9D4IeLzusrMenk4dgJyE/w=;
	b=sZy0vWYctZUeT54qksbqdNQ3Bre2CxXPyjkBs6bP73zeJl9zK+RFM4sitIkcaQAGdn
	+tpmcawbTSwJDYdzS6FLP/U4wztF7uyRPjIJdJ+rwY6J61adsC4DQLNHmFQ4OQ+nKx9Q
	F5SmkizEtg8IsZNbJlzUfdcb/dIrm2TwvBAO8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=X5Yt/f0Vnu2izQ3ngGY/7tdsdAonAoLwO9uVrRMoR7VlndWqmMt+R177boe4D5nPUr
	9WhR5PwiGwy0jiujY7a8X6TT+Dd+cscZYjawNVlfLp0HSOAH9eX6I/ui4mb5/p2+YiPR
	xwKYv+8cY3otgCUsp6h0jQzZZjYTOwGlryV+8=
MIME-Version: 1.0
Received: by 10.204.65.1 with SMTP id g1mr3672166bki.57.1244243739943; Fri, 05 
	Jun 2009 16:15:39 -0700 (PDT)
In-Reply-To: <4A2994DF.1060604@gmail.com>
References: <4A28590D.101@gmail.com>
	<accd96830906050419k7ef2469tb1bb22aad4956fe0@mail.gmail.com>
	<accd96830906050556m660e63cw3c14edfb7f526796@mail.gmail.com>
	<4A2946F4.2010501@gmail.com>
	<accd96830906051038m47104ec1oa79c938949e5ca3e@mail.gmail.com>
	<4A29683C.3030301@gmail.com>
	<accd96830906051306j3423727bgab9175207805041a@mail.gmail.com>
	<4A2994DF.1060604@gmail.com>
Date: Sat, 6 Jun 2009 02:15:39 +0300
Message-ID: <accd96830906051615h797b0648y36845958de7e7be5@mail.gmail.com>
From: Vitaly Magerya <vmagerya@gmail.com>
To: Eitan Adler <eitanadlerlist@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-ports@freebsd.org
Subject: Re: Automatically generate symlinks for virtual categories.
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2009 23:15:42 -0000

Some random comments:
- you really want to add usage [1] ("-d" is intentionally not documented)
- when destdir does not exist the script should make one [2]
- you really want to handle whitespace in paths [3]
- there's no easy way to use an INDEX that is not under portsdir;
  I think that in -i you should specify a path, not a filename [4]

(The patches should be applied in the listed order).

[1] http://tx97.net/pub/patches/auto-symlink-virtual-usage.diff
[2] http://tx97.net/pub/patches/auto-symlink-virtual-destdir.diff
[3] http://tx97.net/pub/patches/auto-symlink-virtual-whitespace.diff
[4] http://tx97.net/pub/patches/auto-symlink-virtual-index.diff