Date: Wed, 08 Dec 2004 14:49:57 -0200 From: =?ISO-8859-1?Q?Jo=E3o_Carlos_Mendes_Lu=EDs?= <jonny@jonny.eng.br> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: freebsd-hubs@FreeBSD.org Subject: Re: cvsup-mirror rewrite Message-ID: <41B730B5.5040100@jonny.eng.br> In-Reply-To: <20041208082000.GP79919@obiwan.tataz.chchile.org> References: <20041207231019.GL79919@obiwan.tataz.chchile.org> <XFMail.20041207193827.jdp@polstra.com> <20041208082000.GP79919@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeremie Le Hen wrote:
> [ This is a small conversation I had with jdp@ yesterday evening. Hub
> owners, please, read it and let me know your feelings about this. ]
>
> On Tue, Dec 07, 2004 at 07:38:27PM -0800, John Polstra wrote:
>
>>On 07-Dec-2004 Jeremie Le Hen wrote:
>>
>>>I'm planning to rewrite some parts of cvsup-mirror to make it cleaner.
>>>Here is what I want to do for the moment:
>>>
>>> o I wish to make the dependency on cvsupd optionnal for those like
>>> me who just want to have a local copy of the FreeBSD CVS
>>> repository.
I don't quite see any useful reason for this, but if this does not brake
anything else, no problem.
>>>
>>> o I would also like to move etc/cvsup/update.sh to something like
>>> /usr/local/libexec/cvsup-mirror.sh, following the example of the
>>> atrun command executed from cron(8) [1].
I'd expect more work on customizing update.sh to allow it's
configuration to come from /etc/rc.conf or some other place not touched
during upgrades. As jdp stated, an upgrade is not easy right now.
Where the real script lives is not a big problem at all. See below...
>>>
>>> o I think it would be relevant to move the etc/rc.d/sup.client/
>>> directory to /var/db/, just as it has been done recently in
>>> RELENG_5 and HEAD for example supfiles [2].
This would break the (weak) assumption that a port is fully under
${DESTDIR}. There are already some ports that do this, including some
I've made myself, but it's not something I'm proud of. ;-)
Off course, a configurable update.sh would allow anybody chose where to
put it, but I would rather not make the default be outside ${DESTDIR}.
>>>
>>> o Move cvsup-mirror specific files to etc/rc.d/cvsup/mirror/ to
>>> have a clearer hierarchy.
rc.d???
Is this right? rc.d is for startup script, this would be a very bad place!
But indeed I'd rather have all files in ${PREFIX}/cvsup-mirror instead
of ${PREFIX}/etc/cvsup
>>>
>>>That's all what I thought about for the moment, but I'll maybe find
>>>other things to do while working on it.
I don't know if this is possible, but my wishlist includes some change
to avoid using symbolic links on the prefixes/ subdir and instead list
the prefixes in a text file, where it could be safely saved in a CVS repo.
With this and above changes a upgrade would be simply a matter of
changing the scripts and keeping the site config files.
>>>
>>>I prefer to taste your opinion on the subject before beginning my work.
>>>Would you be interested in commiting such changes ? Do you have any
>>>comments on things I described above or additional ideas ?
>>>
>>>[1] obiwan:libexec# grep atrun /etc/crontab
>>> */5 * * * * root /usr/libexec/atrun
>>>
>>>[2] obiwan:cvsup# grep /var/db /usr/share/examples/cvsup/standard-supfile
>>> *default base=/var/db
>>
>>I think your ideas are reasonable, but they could cause problems for
>>mirror sites that upgraded to a new version of cvsup-mirror. Lots of
>>files wouldn't be in the expected places. On the other hand, it's not
>>particularly easy to upgrade an existing cvsup-mirror installation
>>even now.
>>
>>If you want to make these changes, I think you should get the opinions
>>of the folks on the freebsd-hubs mailing list first. They're the main
>>users of this port.
>>
>>I don't have time to commit your changes, but I wouldn't object at all
>>if you would (a) take over maintainership of the port, and (b) find
>>another committer to do the commits for you.
>
>
> In particular, I want to know if some hub administrators are against
> this kind of changes and why. Furthermore, I would like to gather
> ideas on the hypotetical upgrade method.
>
> Regards,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41B730B5.5040100>