Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jul 2012 05:24:35 GMT
From:      Warren Block <wblock@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/170059: [devel/arduino][patch] Fix missing menu icon
Message-ID:  <201207220524.q6M5OZIL092968@red.freebsd.org>
Resent-Message-ID: <201207220530.q6M5U4kU006939@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         170059
>Category:       ports
>Synopsis:       [devel/arduino][patch] Fix missing menu icon
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 22 05:30:04 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Warren Block
>Release:        9.1-PRERELEASE
>Organization:
>Environment:
FreeBSD lightning 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r238656: Fri Jul 20 11:56:39 MDT 2012     root@lightning:/usr/obj/usr/src/sys/LIGHTNING  amd64
>Description:
If devel/arduino was installed with the Docs option disabled, no icon was available for the desktop menu entry.
>How-To-Repeat:
Turn off the Docs option, install devel/arduino, look in desktop menu under Development.  No Arduino icon is visible.
>Fix:
Apply patch.

Patch attached with submission follows:

diff -u devel/arduino.old/Makefile devel/arduino/Makefile
--- devel/arduino.old/Makefile	2012-07-12 12:50:36.000000000 -0600
+++ devel/arduino/Makefile	2012-07-21 22:59:31.000000000 -0600
@@ -5,6 +5,7 @@
 
 PORTNAME=	arduino
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel java lang
 MASTER_SITES=	GOOGLE_CODE
@@ -30,7 +31,7 @@
 REINPLACE_ARGS=	-i ""
 
 DESKTOP_ENTRIES=	"Arduino" "Arduino IDE" \
-			${PREFIX}/${PORTNAME}/reference/img/logo.png \
+			${PREFIX}/${PORTNAME}/logo.png \
 			"arduino" "Development;IDE;" "false"
 
 OPTIONS_DEFINE+=	DOCS EXAMPLES
@@ -60,6 +61,9 @@
 	@${RM} ${WRKSRC}/lib/RXTXcomm.jar
 	@${LN} -s ${JAVA_HOME}/lib/ext/RXTXcomm.jar ${WRKSRC}/lib/RXTXcomm.jar
 
+	@${MV} ${WRKSRC}/reference/img/logo.png ${WRKSRC}/
+	@${RM} -rf ${WRKSRC}/reference/img/
+
 .if empty(PORT_OPTIONS:MDOCS)
 	@${RM} -rf ${WRKSRC}/reference
 .endif
Common subdirectories: devel/arduino.old/files and devel/arduino/files
Only in devel/arduino: make-plist
diff -u devel/arduino.old/pkg-plist devel/arduino/pkg-plist
--- devel/arduino.old/pkg-plist	2012-07-12 12:50:36.000000000 -0600
+++ devel/arduino/pkg-plist	2012-07-21 23:17:49.000000000 -0600
@@ -337,6 +337,7 @@
 arduino/libraries/Wire/keywords.txt
 arduino/libraries/Wire/utility/twi.c
 arduino/libraries/Wire/utility/twi.h
+arduino/logo.png
 %%REFDOCS%%arduino/reference/Abs.html
 %%REFDOCS%%arduino/reference/AnalogRead.html
 %%REFDOCS%%arduino/reference/AnalogReference.html
@@ -614,7 +615,6 @@
 %%REFDOCS%%arduino/reference/arduinoWide.css
 %%REFDOCS%%arduino/reference/arduinoWideRender.css
 %%REFDOCS%%arduino/reference/environment.html
-%%REFDOCS%%arduino/reference/img/logo.png
 %%REFDOCS%%arduino/reference/index.html
 arduino/revisions.txt
 arduino/tools/Mangler/make.sh
@@ -624,7 +624,6 @@
 @dirrm arduino/tools/Mangler/src
 @dirrm arduino/tools/Mangler
 @dirrm arduino/tools
-%%REFDOCS%%@dirrm arduino/reference/img
 %%REFDOCS%%@dirrm arduino/reference
 @dirrm arduino/libraries/Wire/utility
 %%EXAMPLES%%@dirrm arduino/libraries/Wire/examples/slave_sender
Only in devel/arduino: work


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207220524.q6M5OZIL092968>