From owner-svn-src-head@freebsd.org Tue Jul 28 13:44:22 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D471C36A532; Tue, 28 Jul 2020 13:44:22 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BGHw63WGHz4R9R; Tue, 28 Jul 2020 13:44:22 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from disco.vangyzen.net (unknown [70.97.188.230]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 8481556487; Tue, 28 Jul 2020 08:44:14 -0500 (CDT) Subject: Re: svn commit: r363607 - head/sys/vm To: Mark Johnston , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202007271425.06REPBtv075771@repo.freebsd.org> From: Eric van Gyzen Message-ID: Date: Tue, 28 Jul 2020 08:44:11 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <202007271425.06REPBtv075771@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BGHw63WGHz4R9R X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:36236, ipnet:2607:fc50:1000::/36, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 13:44:22 -0000 On 7/27/20 9:25 AM, Mark Johnston wrote: > + > + /* > + * We may be attempting to free the page as part of the handling for an > + * I/O error, in which case the page was xbusied by a different thread. > + */ > + vm_page_xbusy_claim(m); I've just noticed that vm_page_xbusy_claim() ignores the WAITERS bit. Is this not a problem in practice? Eric