From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr  6 20:21:46 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B7DF816A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  6 Apr 2004 20:21:46 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 99B9143D39
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  6 Apr 2004 20:21:46 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i373KJbv023231	for <freebsd-bugs@freefall.freebsd.org>;
	Tue, 6 Apr 2004 20:20:19 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i373KJw7023230;
	Tue, 6 Apr 2004 20:20:19 -0700 (PDT)
	(envelope-from gnats)
Resent-Date: Tue, 6 Apr 2004 20:20:19 -0700 (PDT)
Resent-Message-Id: <200404070320.i373KJw7023230@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Stephan Uphoff <ups@tree.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8775816A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  6 Apr 2004 20:11:43 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 81CCB43D1D
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  6 Apr 2004 20:11:43 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i373AP72010754
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 6 Apr 2004 20:10:25 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i373APrI010753;
	Tue, 6 Apr 2004 20:10:25 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200404070310.i373APrI010753@www.freebsd.org>
Date: Tue, 6 Apr 2004 20:10:25 -0700 (PDT)
From: Stephan Uphoff <ups@tree.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: kern/65278: [patch] sio: kgdb debugger port initialization destroys
	default serial console speed
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 03:21:46 -0000


>Number:         65278
>Category:       kern
>Synopsis:       [patch] sio: kgdb debugger port initialization destroys default serial console speed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 06 20:20:19 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Stephan Uphoff
>Release:        current
>Organization:
>Environment:
N/A
>Description:
kgdb debugger port initialization in sio.c destroys default 
serial console baud rate (comdefaultrate) if booted using a 
serial console ( boothowto & RB_SERIAL).

>How-To-Repeat:
Use sio0 as console and sio1 as kgdb port.
Boot using the serial console.

After boot-up comdefaultrate will contain an arbitrary value based on
the state of the divisor of the gdb remote port.

>Fix:
Restrict comdefaultrate changes to console ports.


==== //depot/tree/orca/src/sys/dev/sio/sio.c#2 - /usr/develop/tree/orca/src/sys/dev/sio/sio.c ====
@@ -2945,7 +2945,7 @@
 				continue;
 			iobase = port;
 			s = spltty();
-			if (boothowto & RB_SERIAL) {
+			if ((boothowto & RB_SERIAL) && COM_CONSOLE(flags)) {
 				boot_speed =
 				    siocngetspeed(iobase, comdefaultrclk);
 				if (boot_speed)

>Release-Note:
>Audit-Trail:
>Unformatted: