From owner-dev-commits-src-main@freebsd.org Wed Mar 10 18:39:46 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D4363573373; Wed, 10 Mar 2021 18:39:46 +0000 (UTC) (envelope-from cognet@ci0.org) Received: from kanar.ci0.org (kanar.ci0.org [IPv6:2001:bc8:35e6::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "sd-143795", Issuer "sd-143795" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dwgq64ZVWz4Sk8; Wed, 10 Mar 2021 18:39:46 +0000 (UTC) (envelope-from cognet@ci0.org) Received: from kanar.ci0.org (localhost [127.0.0.1]) by kanar.ci0.org (8.16.1/8.16.1) with ESMTPS id 12AIdYBd004713 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 10 Mar 2021 19:39:34 +0100 (CET) (envelope-from cognet@ci0.org) Received: (from doginou@localhost) by kanar.ci0.org (8.16.1/8.16.1/Submit) id 12AIdYo1004712; Wed, 10 Mar 2021 19:39:34 +0100 (CET) (envelope-from cognet@ci0.org) X-Authentication-Warning: kanar.ci0.org: doginou set sender to cognet@ci0.org using -f Date: Wed, 10 Mar 2021 19:39:34 +0100 From: Olivier Houchard To: Jessica Clarke Cc: Olivier Houchard , John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: c328f64d8107 - main - arm64: Fix COMPAT_FREEBSD32. Message-ID: References: <202103101807.12AI7IVW089870@gitrepo.freebsd.org> <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org> X-Rspamd-Queue-Id: 4Dwgq64ZVWz4Sk8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 18:39:46 -0000 Hi Jessica, On Wed, Mar 10, 2021 at 06:36:35PM +0000, Jessica Clarke wrote: > On 10 Mar 2021, at 18:07, Olivier Houchard wrote: > > > > The branch main has been updated by cognet: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c328f64d81079bad5064c8a387883df50ab5aaed > > > > commit c328f64d81079bad5064c8a387883df50ab5aaed > > Author: Olivier Houchard > > AuthorDate: 2021-03-10 18:01:41 +0000 > > Commit: Olivier Houchard > > CommitDate: 2021-03-10 18:06:42 +0000 > > > > arm64: Fix COMPAT_FREEBSD32. > > > > The ENTRY() macro was modified by commit > > 28d945204ea1014d7de6906af8470ed8b3311335 to add an optional NOP instruction > > at the beginning of the function. It is of course an arm64 instruction, so > > unsuitable for the 32bits sigcode. So just use EENTRY() instead for > > aarch32_sigcode. This should fix receiving signals when running 32bits > > binaries on FreeBSD/arm64. > > Hmm, that's a good point, does the extra nop for the AArch64 sigcode > cause issues for gdb detecting it? > > Perhaps we should upstream CheriBSD's SIGCODE macros?.. > I wondered about that, but decided not to dig that rabbit hole :) Having specific macros would certainly make sense. Olivier