From owner-cvs-src@FreeBSD.ORG Tue Oct 12 15:45:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFF1E16A4F8 for ; Tue, 12 Oct 2004 15:45:36 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9810343D46 for ; Tue, 12 Oct 2004 15:45:36 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 29971 invoked from network); 12 Oct 2004 15:45:36 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 12 Oct 2004 15:45:35 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i9CFjSRQ091976; Tue, 12 Oct 2004 11:45:31 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 12 Oct 2004 10:37:00 -0400 User-Agent: KMail/1.6.2 References: <200410111952.i9BJqVXl083724@repoman.freebsd.org> <200410111608.18915.jhb@FreeBSD.org> <416B0075.1020006@root.org> In-Reply-To: <416B0075.1020006@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410121037.00260.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2004 15:45:38 -0000 On Monday 11 October 2004 05:51 pm, Nate Lawson wrote: > John Baldwin wrote: > > On Monday 11 October 2004 03:52 pm, Nate Lawson wrote: > >>njl 2004-10-11 19:52:31 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c > >> Log: > >> Add acpi attachments for ISA sound drivers. This is needed so they'll > >> probe and attach when ACPI is enabled. > >> > >> Submitted by: takawata (sbc fix) > >> MFC after: 1 day > > > > This should only be needed for PnP BIOS cards, not just plain old ISA PnP > > cards. The es1888.c file is only a driver on Alpha in fact as it > > basically includes a dummy identify routine to make up for the lack of > > PnP BIOS on Alphas. > > Which of those cards should have the acpi attachment removed? I think > it should be: > > * Removed from es1888.c > * Added to ess.c:esscontrol > * Moved from mss.c:snd_mss to snd_pnpmss My gut feeling is that only sbc(4) is actually integrated in motherboards (note that ACPI and PnP BIOS aren't for PNP ISA cards, but for devices integrated into the motherboard itself, and not PCI soundcards) but it doesn't hurt to have the attachment for all PNP-aware ISA sound drivers I guess. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org