From nobody Mon Jan 15 23:39:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TDTBQ2YF8z57qXv; Mon, 15 Jan 2024 23:39:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TDTBP5q6rz4HB3; Mon, 15 Jan 2024 23:39:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705361965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2I2mW4/M5VO8WEHobzR5/ciUw4X1cfaR/wL3wTgpFsg=; b=jibKdRRgD4eFR21kmKPqlhBAgQma9YxSXrQ34/I+SeKCeYkmnsgPBDdzZDQKgDZwRR0Boy 6kfqrJsPr9wDS3YGD5lue4mJHje8pNqmZ7g6JcrnA/8CuwLuvBMFlRI7tz1FI5Y2r02zFx vIRj2/OVaRyC19X1eYK9X5te0oxolvXZTMBbAtvN5E0t6Z9r3zLOLk29LPFLgZmurMGtY8 SHFsQqvz2ZWQ1dtZLTmj++r2WmJmGHZ+tyMwJQ1nIad8VcXQ84nAsL/WKRoOBIwYqy8j54 Y4g8shax6y7dsN9Iz7Dwu397wYSW/T0ZDO0DKAszdddK8ldW2yXUTaI7el7Y7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705361965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2I2mW4/M5VO8WEHobzR5/ciUw4X1cfaR/wL3wTgpFsg=; b=nxLuw6ZuSk1OMZYim3rTo0NV5CDBHMGjpnUiXWEzlP4kR2f//BanFTXs3Jai1PjRoJfmSP TD7k1BFdwHM+lxgfm7R5i/WYE0sJRW0ge79YgijjePsH+GtG1G73XSpy/ox+Q/AcH48Wz9 jo/bG1RMr0mOEO32Br6CvDLE2h58kFtCX/6xsWwJD4Eql8INHKtmSb1DFBUWi7TbzIkksM GbKtaIQLRR+HNYMRivRwySfyp/hmrgTgbIxs918udJLtgueSmGRPeBxCOiQj2D8xpw2Mnt 3vXsgciT1ER0+ZKFEJQ1ZN07UBBavJo/gqjaORDf5Jw1DBqgyKqCVQQOXLruZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705361965; a=rsa-sha256; cv=none; b=fN9Jn8LkqR4eUtbs4vrwtuw5WxxHrKYfGZymqYBnAbJ6QoUS/ZZTXQddeiy50UHefIqIP9 8w2GY+EjwG5ufxxaiSdiCUdOBWxiYM4mMvRQOsEi/rPVkGsKWs38ZLbPYtKN9qf4n5c7+0 UKAUBoX3MaW9ZgDLlO37uydEnnAql50bF5yMfik4Ss700oqfPuvVgXOsysmGJBPJmJcFdI 1+qN/0Q+udBQK6Zq6rUKW2j68xcDgpdYEg9PQFSL04Hsq5IKJQzi7VrApXqRO6n454ocEK /5mNfPdjYww9pJJvLXJe52p534+Jkf2j1IcUXpbHPEu2rkv3v99jnSZCPzPoFQ== Received: from [IPV6:2601:644:9381:f410:11eb:4f99:4a77:931] (unknown [IPv6:2601:644:9381:f410:11eb:4f99:4a77:931]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TDTBP0tsZzRcV; Mon, 15 Jan 2024 23:39:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <046cef05-668a-4ee9-a72a-09d7de303a46@FreeBSD.org> Date: Mon, 15 Jan 2024 15:39:23 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log Content-Language: en-US To: Warner Losh Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/15/24 9:02 AM, Warner Losh wrote: > Hey John, > > On Mon, Jan 15, 2024 at 9:37 AM Warner Losh wrote: > >> >> >> On Mon, Jan 15, 2024 at 9:30 AM John Baldwin wrote: >> >>> On 1/14/24 6:24 PM, Warner Losh wrote: >>>> The branch main has been updated by imp: >>>> >>>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=df834e06bbc78c03cb6b35f074ae43673c9ce463 >>>> >>>> commit df834e06bbc78c03cb6b35f074ae43673c9ce463 >>>> Author: Warner Losh >>>> AuthorDate: 2024-01-15 02:22:04 +0000 >>>> Commit: Warner Losh >>>> CommitDate: 2024-01-15 02:23:45 +0000 >>>> >>>> git-arc: Just strip escape sequences form arc log >>>> >>>> Just strip escape sequences and Warning: lines from 'arc list' >>> output. I >>>> upgraded and they changed and git arc list broke. This restores its >>>> functionality. >>>> >>>> Note: jhb didn't like this, so if others object, I'll fix... >>>> >>>> Sponsored by: Netflix >>>> Reviewed by: markj >>>> Differential Revision: https://reviews.freebsd.org/D36553 >>> >>> Namely, it breaks the color output for reviews in different states, so >>> Needs Review >>> shows up as purple, Approved as green, etc. If you find the color output >>> useful >>> you'll have to revert this locally. >>> >>> Also, your last update in the review said that git arc was no longer >>> broken for you >>> back in May implying this commit wasn't needed for git arc to work for >>> you? >>> >> >> Yes and no. I was mistaken. This change is still needed, but its scope can >> be reduced. >> The trouble is that it's at the first for the other things I committed and >> getting it out of the >> way was a pain (I tried). Since I didn't want to delay things any further, >> I went ahead and >> committed and thought I'd fix stuff if there were objections.I'll do that >> now. >> > > So even w/o my change, I don't see the color output for the review states > (so I can remove the > general filter I added for color). That's easy enough. but what are you > doing to get color in the > current setup? Or is your arcanist install old and un-updated? Nope, built locally via poudriere back in October on 14-stable: > pkg info | grep arcan arcanist-lib-php81-20220518_5 Libraries for the command line interface for Phabricator arcanist-php81-20220518_5 Command line interface for Phabricator > ll /usr/local/poudriere/data/logs/bulk/14_0-20231022-ports/*/arcanist* -rw-r--r-- 3 root wheel 16185 Oct 22 22:34 /usr/local/poudriere/data/logs/bulk/14_0-20231022-ports/latest-per-pkg/arcanist-lib-php81-20220518_5.log -rw-r--r-- 3 root wheel 14152 Oct 22 22:56 /usr/local/poudriere/data/logs/bulk/14_0-20231022-ports/latest-per-pkg/arcanist-php81-20220518_5.log Can't show color arc list output via text e-mail, but it's color, and git arc list is still color for me (from commit 613aaf59afa307fc77c8eed01962a59423b1c5f3). arc list | more shows all the escape codes, but arc list | less -R shows the colors just fine. This is in konsole with TERM=xterm256-color. It also works fine for me in plain xterm under i3wm on my X1 carbon running main from September with arcanist built in September. -- John Baldwin