From owner-p4-projects@FreeBSD.ORG Mon Apr 10 18:57:18 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 351EA16A40A; Mon, 10 Apr 2006 18:57:18 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E768216A405 for ; Mon, 10 Apr 2006 18:57:17 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 399F343D68 for ; Mon, 10 Apr 2006 18:57:15 +0000 (GMT) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3AIvFER035674 for ; Mon, 10 Apr 2006 18:57:15 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3AIvFF2035668 for perforce@freebsd.org; Mon, 10 Apr 2006 18:57:15 GMT (envelope-from imp@freebsd.org) Date: Mon, 10 Apr 2006 18:57:15 GMT Message-Id: <200604101857.k3AIvFF2035668@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 94940 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2006 18:57:18 -0000 http://perforce.freebsd.org/chv.cgi?CH=94940 Change 94940 by imp@imp_Speedy on 2006/04/10 18:56:56 Nits, but important ones that makes the download work. Affected files ... .. //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/xmodem.c#4 edit Differences ... ==== //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/xmodem.c#4 (text+ko) ==== @@ -55,7 +55,7 @@ goto err; if ((ch = getc(1)) == -1) goto err; - if (ch != ~blocknum & 0xff) + if (ch != (~blocknum & 0xff)) goto err; for (size = 0; size < PACKET_SIZE; ++size) { @@ -73,10 +73,10 @@ chk &= 0xFFFF; - if (((ch = getc(1)) == -1) || (ch & 0xff != ((chk >> 8) & 0xFF))) - goto err; - if (((ch = getc(1)) == -1) || (ch & 0xff != (chk & 0xFF))) - goto err; + if (((ch = getc(1)) == -1) || ((ch & 0xff) != ((chk >> 8) & 0xFF))) + goto err; + if (((ch = getc(1)) == -1) || ((ch & 0xff) != (chk & 0xFF))) + goto err; putc(ACK); return (1);