From owner-freebsd-hackers@FreeBSD.ORG Wed Jan 18 02:39:50 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CD4C106564A for ; Wed, 18 Jan 2012 02:39:50 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 508DB8FC0A for ; Wed, 18 Jan 2012 02:39:49 +0000 (UTC) Received: from pps.filterd (ltcfislmsgpa02 [127.0.0.1]) by ltcfislmsgpa02.fnfis.com (8.14.4/8.14.4) with SMTP id q0I2PPp3029824; Tue, 17 Jan 2012 20:39:49 -0600 Received: from smtp.fisglobal.com ([10.132.206.16]) by ltcfislmsgpa02.fnfis.com with ESMTP id 12djc0ggpw-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 17 Jan 2012 20:39:49 -0600 Received: from dtwin (10.14.152.15) by smtp.fisglobal.com (10.132.206.16) with Microsoft SMTP Server (TLS) id 14.1.323.3; Tue, 17 Jan 2012 20:39:49 -0600 From: Devin Teske To: "'Garrett Cooper'" References: <03b301ccd587$eba40d00$c2ec2700$@fisglobal.com> In-Reply-To: Date: Tue, 17 Jan 2012 18:40:13 -0800 Message-ID: <03b501ccd58a$81f211b0$85d63510$@fisglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQNXDRfHss6TvyDxsi9N5T/yyn3P/wIcRzglkuwWPtA= Content-Language: en-us X-Originating-IP: [10.14.152.15] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2012-01-17_09:2012-01-17, 2012-01-17, 1970-01-01 signatures=0 Cc: freebsd-hackers@freebsd.org Subject: RE: 14 month old regression (how?) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2012 02:39:50 -0000 > -----Original Message----- > From: Garrett Cooper [mailto:yanegomi@gmail.com] > Sent: Tuesday, January 17, 2012 6:29 PM > To: Devin Teske > Cc: freebsd-hackers@freebsd.org > Subject: Re: 14 month old regression (how?) > > On Tue, Jan 17, 2012 at 6:21 PM, Devin Teske > wrote: > > Looking at bin/164192... > > > > I'm left wondering to myself... > > How on Earth did a regression-by-typo introduced in SVN r214735 go 14 > > months without being noticed? > > Very carefully. I've seen it happen before on paid products (in fact I've fixed 15 > year old bugs thanks to my colorized editor, and I'm sure someone's going to find > bugs I've made 1, 5, 10, or 20 years in the future..).. people make mistakes -- it's a > fact of life. > -Garrett I found the reason why this typo wasn't noticed. Appears that "${WPA_DISTDIR}/src/crypto" is already being declared one-level-up in the following file: src/usr.sbin/wpa/Makefile.inc Otherwise, buildworld would have failed in src/usr.sbin/wpa/wpa_supplicant complaining about undefined references while linking wpa_supplicant. The patch in bin/164192 still stands, but I'm going to amend the PR to explain why this typo went unnoticed for 14 months. -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.