From owner-cvs-src@FreeBSD.ORG  Wed Dec 17 20:49:38 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A9A4A16A4CE; Wed, 17 Dec 2003 20:49:38 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BBC8943D5D; Wed, 17 Dec 2003 20:49:26 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id PAA21979;
	Thu, 18 Dec 2003 15:49:21 +1100
Date: Thu, 18 Dec 2003 15:49:19 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
In-Reply-To: <20031216234544.S68813@root.org>
Message-ID: <20031218153640.F18847@gamplex.bde.org>
References: <20031217025641.57B6916A545@hub.freebsd.org>
	<20031216234544.S68813@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: "Jordan K. Hubbard" <jkh@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/include regex.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2003 04:49:38 -0000

On Tue, 16 Dec 2003, Nate Lawson wrote:

> On Tue, 16 Dec 2003, Jordan K. Hubbard wrote:
> >   Modified files:
> >     include              regex.h
> >   Log:
> >   Conformance: Add REG_ENOSYS (see http://www.opengroup.org/onlinepubs/007904975/basedefs/regex.h.html)
> >
> >   Revision  Changes    Path
> >   1.7       +1 -0      src/include/regex.h
> >
> >
> > Index: src/include/regex.h
> > diff -u src/include/regex.h:1.6 src/include/regex.h:1.7
> > --- src/include/regex.h:1.6	Thu Oct  3 11:12:03 2002
> > +++ src/include/regex.h	Tue Dec 16 18:56:28 2003
> > @@ -75,6 +75,7 @@
> >  #define	REG_DUMP	0200
> >
> >  /* regerror() flags */
> > +#define REG_ENOSYS	-1	/* Reserved */
> >  #define	REG_NOMATCH	 1
> >  #define	REG_BADPAT	 2
> >  #define	REG_ECOLLATE	 3
>
> Same.

Not quite the same :-).  This commit shares the following other bugs with
the corresponding commit to fnmatch.h:

- missing parentheses around macro.
- abnormal comment style.  The comment style in this file was perfectly
  abnormal (unlike in fnmatch.h where it was normal).  The new comment
  matches neither, since it begins the sentence fragment with a capital
  letter (like the normal style but unlike the rest of the file) and
  it doesn't end the sentence fragment with a "." (unlike the normal
  style but like the rest of the file).

... but doesn't share the following:

- namespace pollution.  There is none here since REG_ENOSYS is only
  obsolescent; it is not an XSI extension.
- new macro in a section all by itself.  Here it is even numerically sorted.

Bruce