From owner-freebsd-current@FreeBSD.ORG Mon Apr 23 17:44:14 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 024E4106566C for ; Mon, 23 Apr 2012 17:44:14 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id B02C68FC16 for ; Mon, 23 Apr 2012 17:44:13 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:60a9:25db:2120:9de1] (unknown [IPv6:2001:7b8:3a7:0:60a9:25db:2120:9de1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E1C3D5C37; Mon, 23 Apr 2012 19:44:12 +0200 (CEST) Message-ID: <4F9594EA.3050108@FreeBSD.org> Date: Mon, 23 Apr 2012 19:44:10 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120410 Thunderbird/12.0 MIME-Version: 1.0 To: Andrew Boyer References: <3C479FEC-971A-4099-9CA5-B522574BE763@averesystems.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Current FreeBSD , Greg Bednarek Subject: Re: Fwd: Memory leak in authunix_create_default()... X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 17:44:14 -0000 On 2012-04-23 19:31, Andrew Boyer wrote: > Begin forwarded message: > >> From: Greg Bednarek >> Date: April 16, 2012 10:54:33 AM EDT >> To: freebsd-current@freebsd.org >> Cc: Andrew Boyer >> Subject: Memory leak in authunix_create_default()... >> >> >> Please see the attached patch for a proposed fix for a memory leak in authunix_create_default(). >> >> The leak appears to have been introduced 6/19/2009 in Revision 194494 of lib/libc/rpc/auth_unix.c >> >> As you can see form the patch, the fix is very simple. The issue was discovered when tracking down some rather drastic increases in application memory footprint during certain types of workloads, and was eventually traced it to this (apparently) not very heavily used path in libc. >> >> I would appreciate hearing any comments/concerns with the proposed fix. Hi, The patch itself seems to have gone missing?