From owner-freebsd-current@FreeBSD.ORG Fri Aug 23 18:05:14 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 55FE9EB7; Fri, 23 Aug 2013 18:05:14 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 11AA82822; Fri, 23 Aug 2013 18:05:14 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r7NI5Dgp011777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Aug 2013 11:05:13 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r7NI5DDN011776; Fri, 23 Aug 2013 11:05:13 -0700 (PDT) (envelope-from jmg) Date: Fri, 23 Aug 2013 11:05:13 -0700 From: John-Mark Gurney To: Mike Tancsa Subject: Re: patch to improve AES-NI performance Message-ID: <20130823180513.GM94127@funkthat.com> Mail-Followup-To: Mike Tancsa , Ollivier Robert , freebsd-current@freebsd.org, security@freebsd.org References: <20130822202027.GH94127@funkthat.com> <20130823151615.GD41379@roberto02-aw.erc.corp.eurocontrol.int> <52177F0B.9020906@sentex.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52177F0B.9020906@sentex.net> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 23 Aug 2013 11:05:13 -0700 (PDT) Cc: Ollivier Robert , freebsd-current@freebsd.org, security@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 18:05:14 -0000 Mike Tancsa wrote this message on Fri, Aug 23, 2013 at 11:26 -0400: > On 8/23/2013 11:16 AM, Ollivier Robert wrote: > > According to John-Mark Gurney on Thu, Aug 22, 2013 at 01:20:27PM -0700: > >> I have developed a patch to improve AES-NI performance. If you took the > >> AES-XTS algorithm into userland (no cryptodev or geli usage), these > >> changes improve the performance over 10x in my tests (from ~150MB/sec to > >> over 2GB/sec). In tests of geli on gnop, the performance improvement is > >> more moderate, around 4x due to overhead in other parts of the system. > > > > Thanks a lot for this patch. Now, looking at it in the stable/9 context, I can see that pjd did not merge (as he said at the time of commit) r226839 & r226839. Is there any objection to merge these two (and possibly 247061 as well -- copyright update)? > > > > I ask that for two reasons, these two revisions are speeding up AES-NI quite a bit and they are required for using jmg's patch. > > > > I'll be testing all this in the next few days on my new AES-NI enabled machine. > > > > Speeding up userland AES is very interesting to me for a couple of apps. > If there is a proper way I should test on RELENG_9, please let me know > as I am few boxes that I would be happy to test/deploy on. My patch would only effect userland applications that use /dev/crypto... If they do their own AES-NI work, then there isn't any improvement... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."