Date: Sun, 21 Aug 2016 09:06:39 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Message-ID: <bug-209742-13-aMuQimIE2c@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org --- Comment #67 from Jan Beich <jbeich@FreeBSD.org> --- Created attachment 173905 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173905&action= =3Dedit style cleanup poudriere bulk -t is green for 9.3R-i386, 9.3R-amd64, 10.1R-i386, 10.3R-amd= 64, 11.0R-i386 here. > USE_GITHUB=3D yes > GH_ACCOUNT=3D godotengine > +GH_TAGNAME_DEMOS=3D dfa1274 [...] > +EXAMPLES_GH_TUPLE=3D godotengine:godot-demo-projects:${GH_TAGNAME_DEMOS}= :DEMOS GH_TAGNAME_DEMOS kind of defeats the simplicity of GH_TUPLE. "godotengine" = can also be replaced with "${GH_ACCOUNT}". And if you have a rationale to choos= e a specific commit then better annotate the line via an inline comment. > -USES=3D scons pkgconfig compiler > -USE_OPENSSL=3D yes > +USES=3D scons ssl pkgconfig compiler If you have the chance do sort USES value. > +AUDIO_DESC=3D Supported audio <transitive verb> + <adjective>. Where's a noun? Maybe use "Audio support" = or "Audio backends" instead. > +GODOTFILE=3D ${PORTNAME}${PKGNAMESUFFIX} GODOTFILE=3D${PKGBASE} would be shorter but I don't understand why you need= an extra variable. > +.if ${SLAVE_PORT} =3D=3D yes SLAVE_PORT conditionals are almost always an abomination and often can be replaced with ?=3D variables. > .if ${CHOSEN_COMPILER_TYPE} =3D=3D clang > MAKE_ARGS+=3D use_llvm=3Dyes > .else # clang > USE_GCC=3D yes > .if ${ARCH} =3D=3D i386 > CXXFLAGS+=3D -march=3Di586 > .endif > .endif # clang Another case of logic that can be easily moved above .include <bsd.port.pre.mk>. > do-install-EXAMPLES-on: > (cd ${WRKSRC_DEMOS} && ${COPYTREE_SHARE} "${PORTDATA}" \ > ${STAGEDIR}${DATADIR}/demos) This is confusing. Use PORTEXAMPLES when installing EXMAPLES. > ++#if defined(__FreeBSD__) > ++#define SND_DEVICE "/dev/dsp" > ++#else > ++#define SND_DEVICE "/dev/mixer" > ++#endif __DragonFly__ inherited __FreeBSD__ audio stack, so it may want the same. > + #elif defined(__FreeBSD__) [...] > ++ int mib[4] =3D { CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, -1 }; Maybe replace with #elif defined(KERN_PROC_PATHNAME) which is available on FreeBSD, DragonFly and NetBSD. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-aMuQimIE2c>