From owner-freebsd-ports-bugs@freebsd.org Sun Aug 21 09:06:39 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 258A7BC1203 for ; Sun, 21 Aug 2016 09:06:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F125A1FA5 for ; Sun, 21 Aug 2016 09:06:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7L96cJm045412 for ; Sun, 21 Aug 2016 09:06:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Date: Sun, 21 Aug 2016 09:06:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2016 09:06:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org --- Comment #67 from Jan Beich --- Created attachment 173905 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173905&action= =3Dedit style cleanup poudriere bulk -t is green for 9.3R-i386, 9.3R-amd64, 10.1R-i386, 10.3R-amd= 64, 11.0R-i386 here. > USE_GITHUB=3D yes > GH_ACCOUNT=3D godotengine > +GH_TAGNAME_DEMOS=3D dfa1274 [...] > +EXAMPLES_GH_TUPLE=3D godotengine:godot-demo-projects:${GH_TAGNAME_DEMOS}= :DEMOS GH_TAGNAME_DEMOS kind of defeats the simplicity of GH_TUPLE. "godotengine" = can also be replaced with "${GH_ACCOUNT}". And if you have a rationale to choos= e a specific commit then better annotate the line via an inline comment. > -USES=3D scons pkgconfig compiler > -USE_OPENSSL=3D yes > +USES=3D scons ssl pkgconfig compiler If you have the chance do sort USES value. > +AUDIO_DESC=3D Supported audio + . Where's a noun? Maybe use "Audio support" = or "Audio backends" instead. > +GODOTFILE=3D ${PORTNAME}${PKGNAMESUFFIX} GODOTFILE=3D${PKGBASE} would be shorter but I don't understand why you need= an extra variable. > +.if ${SLAVE_PORT} =3D=3D yes SLAVE_PORT conditionals are almost always an abomination and often can be replaced with ?=3D variables. > .if ${CHOSEN_COMPILER_TYPE} =3D=3D clang > MAKE_ARGS+=3D use_llvm=3Dyes > .else # clang > USE_GCC=3D yes > .if ${ARCH} =3D=3D i386 > CXXFLAGS+=3D -march=3Di586 > .endif > .endif # clang Another case of logic that can be easily moved above .include . > do-install-EXAMPLES-on: > (cd ${WRKSRC_DEMOS} && ${COPYTREE_SHARE} "${PORTDATA}" \ > ${STAGEDIR}${DATADIR}/demos) This is confusing. Use PORTEXAMPLES when installing EXMAPLES. > ++#if defined(__FreeBSD__) > ++#define SND_DEVICE "/dev/dsp" > ++#else > ++#define SND_DEVICE "/dev/mixer" > ++#endif __DragonFly__ inherited __FreeBSD__ audio stack, so it may want the same. > + #elif defined(__FreeBSD__) [...] > ++ int mib[4] =3D { CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, -1 }; Maybe replace with #elif defined(KERN_PROC_PATHNAME) which is available on FreeBSD, DragonFly and NetBSD. --=20 You are receiving this mail because: You are the assignee for the bug.=