From owner-freebsd-current@FreeBSD.ORG Mon Aug 29 18:36:01 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4AE9816A423 for ; Mon, 29 Aug 2005 18:36:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F74743D4C for ; Mon, 29 Aug 2005 18:36:00 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.40.201] (Not Verified[10.50.40.201]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 29 Aug 2005 14:51:04 -0400 From: John Baldwin To: freebsd-current@freebsd.org Date: Mon, 29 Aug 2005 14:24:10 -0400 User-Agent: KMail/1.8 References: <20050828.092209.77060388.imp@bsdimp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508291424.11549.jhb@FreeBSD.org> Cc: "Bjoern A. Zeeb" , "M. Warner Losh" Subject: Re: LOR route vr0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2005 18:36:01 -0000 On Sunday 28 August 2005 11:31 am, Bjoern A. Zeeb wrote: > On Sun, 28 Aug 2005, M. Warner Losh wrote: > > In message: > > > > > > "Bjoern A. Zeeb" writes: > > : On Sat, 27 Aug 2005, M. Warner Losh wrote: > > : > > : for the archives... > > : > > : > ock order reversal > > : > 1st 0xc17490e4 rtentry (rtentry) @ sys/netinet/if_ether.c:445 > > : > 2nd 0xc15c94b0 rl1 (network driver) @ sys/pci/if_rl.c:1451 > > : > > : LOR http://sources.zabbadoz.net/freebsd/lor.html#144 > > > > I cut and pasted this one from your LOR site... > > *gnaa* my grep-o-logic failed. I should really really really split > this page... > > I removed the duplicate. > The original one was http://sources.zabbadoz.net/freebsd/lor.html#139 > > > : > and am seeing the following in my newly locked ed driver: > > : > > > : > lock order reversal > > : > 1st 0xc1cb3588 rtentry (rtentry) @ net/route.c:1269 > > : > 2nd 0xc1fd3420 ed1 (network driver) @ > > : > /dell/imp/p4/newcard/src/sys/modules/ed/../../dev/ed/if_ed.c:697 > > : > > : I added this one two though this LOR may not (yet) be seen in > > : the wild. > > : > > : LOR http://sources.zabbadoz.net/freebsd/lor.html#145 > > > > heh. I'm expecting to figure out what the real LOR is here and then > > about 20-25 of the LORs in your list can go away... > > great. let me know the IDs and the patch that will fix them then. Note that all network driver locks are considered the same in witness (they have a lock "type" of MTX_NETWORK_LOCK). You probably want to look at the lock "type" for LORs and don't log duplicate LORs for the same type. The only widespread case of locks that use a type other than their name are network device drivers. I imagine that other device drivers might do this in the future as well. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org