Date: Fri, 8 Mar 2024 09:52:41 +0100 From: Thierry Thomas <thierry@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Fernando =?iso-8859-1?Q?Apestegu=EDa?= <fernando.apesteguia@gmail.com>, Daniel Engberg <daniel.engberg.lists@pyret.net>, Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: <ZerR2U_mLsfwJ_Ck@graf.pompo.net> In-Reply-To: <ulhaktj3yz6yqkvwdz7wmhjqvgf736m2ehxfqst6vkdikb7o4c@ncvnusw5efsa> References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <CAGwOe2ZE6huqiTAV6zUpJqG6NxmkE2ado2M3oskp972pvBa8DA@mail.gmail.com> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> <CAGwOe2adJ-rES4gpgj-4s8dmHEmrtzRZp%2B%2BmJPYs-LueR3piJQ@mail.gmail.com> <ulhaktj3yz6yqkvwdz7wmhjqvgf736m2ehxfqst6vkdikb7o4c@ncvnusw5efsa>
next in thread | previous in thread | raw e-mail | index | archive | help
--nSPF6jR75E5ArI9R Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le jeu. 7 mars 24 =E0 15:15:30 +0100, Mathieu Arnold <mat@freebsd.org> =E9crivait=A0: > > My main point is this. We should mark ports as BROKEN when *they* are > > broken, not when the dependencies are. >=20 > In this case, the dependency was not broken in the sense that it built > just fine. > We mark ports BROKEN because they don't build, so that the FreeBSD ports > infrastructure does not spend hours trying to build stuff that will > never build. Yes, in this case, it would be rather IGNORE and not BROKEN, but Fernando is right: the faulty port should be marked, not its consumers. And the compilation farm will not even try to build them. But yet better: I would prefer that the committer who pushed this commit be notified, and that without a prompt reaction on his part, it be reverted. --=20 Th. Thomas. --nSPF6jR75E5ArI9R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJl6tHYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdT5TwQALq79wRnZJRDHBnKX+jbKDpa ifmW4XJcheu3ixk+FCsHtBwgGQSbvZsITLv9zC8qrdHOpmsrbSUnLDvE0NRwI170 1SoLVHrPhT89Fr3X+k27nGjObzM96ueqPOX1aSoXF2QlfxgCZ1l6slUk9M7Dk88+ NXFWuRU/lqgQlYGtHH3/JX9lB7kUozCNfWKuhL+TwSnKVL4cxNmOWwLAT3ZrbJem PkdlSkTCfRc+AZEeycs5BXv+Ti/U0dLGWljcAec3GXsxw2cU5ijqMdS5D5hL2IHJ GRvpVPD3zB6/NuSBn5IVnnumOW3nMBoUXrCWy7+6Abo5s6O5uhMSLurqgbvJ40iF MB78a0R0AQPR+imsbDnALFiRBOU1p4+VWhMaAp8E17fh1cKY66HpzUI5irIR1f3V sDov3G29hUQyxDZZe5S4jykQ52GM7bKDXIzn+OKgOOrVGLJg7TN8uknWlxLTAuJo vLR0ON4H8YmlX3aGF5ECI8/C0rwri8F8NCKffpyWHBer35JnWHWCYEi1m3fO21Dx EVa4LLMy8k0BxxFxv179CizT5YczG4FQnH0+Rqcdzsw+vN5grk6mwl8IukyfmUxU lOtYkVXGMcaIsxF/MRceFuLF6mTrl/xHh04lXj2iRT4Z8F9lzeTwMSOyGtvz8jf+ yNrP6kkl6iAI/RziD8SQ =oeXB -----END PGP SIGNATURE----- --nSPF6jR75E5ArI9R--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZerR2U_mLsfwJ_Ck>