From owner-cvs-ports@FreeBSD.ORG Tue Dec 20 06:54:23 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A085D106566B; Tue, 20 Dec 2011 06:54:23 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 318C08FC0A; Tue, 20 Dec 2011 06:54:21 +0000 (UTC) Received: by iadj38 with SMTP id j38so8565326iad.13 for ; Mon, 19 Dec 2011 22:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=mLsHsTl7tgjNE+lY33VLp9a+B3A8VDs9MdIElXrM9h4=; b=DlPNFqzSfiKIzAixgqwskgwZAdEzbYjHGVg68Idv1NakG0HLNcj6IgKnwLnhGL3KUO lOUuRmqb8b8r4B5SCk36AGuYBLT3h6ScLPcBmotiBPLs/tc47w55lFBsbUpkMtKz4k2Z x0NVNrkR1zsAwkrKp01zl8Ij8RLVcQTj8sD2o= Received: by 10.42.150.130 with SMTP id a2mr1042201icw.43.1324364061266; Mon, 19 Dec 2011 22:54:21 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.199.18 with HTTP; Mon, 19 Dec 2011 22:53:50 -0800 (PST) In-Reply-To: <4EEFD2B8.1050006@FreeBSD.org> References: <201112181751.pBIHpivv027591@repoman.freebsd.org> <4EEF0AF1.20501@FreeBSD.org> <4EEFD2B8.1050006@FreeBSD.org> From: Chris Rees Date: Tue, 20 Dec 2011 06:53:50 +0000 X-Google-Sender-Auth: y-QLx0jL7-FWbtF7c-Q1uemjZP0 Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@freebsd.org, freebsd-xfce@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/xfce4-utils Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 06:54:23 -0000 On 20 Dec 2011 00:11, "Doug Barton" wrote: > > On 12/19/2011 02:03, Chris Rees wrote: > > > > On 19 Dec 2011 09:59, "Doug Barton" > > wrote: > >> > >> Thanks, that's 1/3 of the job done. :) =A0The problem is that the curr= ent > >> OPTION creates the false idea that the only way you can lock your scre= en > >> is to use xlockmore. > >> > >> Perhaps you missed my followup where I mentioned that the next step > >> would be to add an OPTION for xscreensaver as well, and the logic to > >> avoid having them both defined. > > > > I'll look at that later. > > Thanks. In answer to your question avoiding having both enabled would be > nice since it avoids duplicate, unnecessary redundancy. > > >> Better yet would be to detect if one or the other is already installed= , > >> and default the OPTIONS accordingly. > > > > Autodetection in ports? No thanks! > > I didn't suggest autodetecting for the dependencies, I suggested it for > the OPTIONS. That's been done for a long time, and ideally should be how > it's always done. Ok... a pointer on how that's done would be good. The only way I can think of would be: .if exists(${LOCALBASE}/bin/xlock) OPTIONS+=3D XLOCK "Use xlock for 'lock screen'" on .else OPTIONS+=3D XLOCK "Use xlock for 'lock screen'" off .endif which would be great if LOCALBASE were actually defined before bsd.port.options.mk. I can't see a way to do this. Do you have an example port? Chris