From owner-svn-src-all@FreeBSD.ORG Mon Mar 30 09:10:52 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A9D03C7 for ; Mon, 30 Mar 2015 09:10:52 +0000 (UTC) Received: from o1.l99.sendgrid.net (o1.l99.sendgrid.net [198.37.153.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 32BF9EAF for ; Mon, 30 Mar 2015 09:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=nmwxpVBRXJn0+q3aRrnpsApF4ms=; b=Rj8z1thPUULcI/yEbG FbQcB9Ps2dbaSz15Mf0ULZu19JA6g/dzA7H6efHnidXalTdquRQCxTQqK5ttD3gB hhjjAoh78sMWD4DMszBevpbjcn55XABRPwNSwGajP0+5HjVMqmP6qZFG3jRXi7GA s1yjFWa8sSW44BjJLVwF/nZlw= Received: by filter0442p1mdw1.sendgrid.net with SMTP id filter0442p1mdw1.31950.5519131A8 2015-03-30 09:10:50.516538165 +0000 UTC Received: from mail.tarsnap.com (ec2-54-86-246-204.compute-1.amazonaws.com [54.86.246.204]) by ismtpd-025 (SG) with ESMTP id 14c69f29f03.3727.569548 for ; Mon, 30 Mar 2015 09:10:50 +0000 (UTC) Received: (qmail 91445 invoked from network); 30 Mar 2015 09:09:04 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 30 Mar 2015 09:09:04 -0000 Received: (qmail 33830 invoked from network); 30 Mar 2015 09:07:51 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 30 Mar 2015 09:07:51 -0000 Message-ID: <55191267.3070305@freebsd.org> Date: Mon, 30 Mar 2015 02:07:51 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: NGie Cooper Subject: Re: svn commit: r280840 - head/release/tools References: <201503300833.t2U8XKfe056489@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SG-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PGsyo1guJo9Lwr61yldBfmQ6fcaf2615p8tPM Tp35lCaVobVamLKTZVlg66fiStoz0jBCECxeXMUY/oCOASd0PTY5wZad9DC50tUpSSI7N7Imq8iLmC T4r9i0xGXtMfwY3Dk/8ZKge0zHkjMw1BzL1U Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 09:10:52 -0000 On 03/30/15 02:04, NGie Cooper wrote: > On Mon, Mar 30, 2015 at 2:03 AM, NGie Cooper wrote: >> On Mon, Mar 30, 2015 at 1:33 AM, Colin Percival wrote: >>> cleanup() { >>> + if mount | grep -qE "devfs on ${DESTDIR}/dev"; then >>> + umount_loop ${DESTDIR}/dev 2>/dev/null >>> + fi >> >> if [ -c "${DESTDIR}/dev" ]; then > > I meant: > > [ -c "${DESTDIR}/dev/null" ] Thanks! I was looking for a way to express "if this is a mount point" but I completely forgot that there are things which are reliably present *inside* a devfs... ... and looking at what I committed earlier I see now that I missed a ^ at the start of the regex anyway, so my first attempt was both a bad idea *and* wrong. ;-) -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid