Date: Mon, 30 Mar 2015 02:07:51 -0700 From: Colin Percival <cperciva@freebsd.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r280840 - head/release/tools Message-ID: <55191267.3070305@freebsd.org> In-Reply-To: <CAGHfRMC4ikAnJ_51HnJqW9FYSgofZJbjMAkXKmUdCBtOJiYO-Q@mail.gmail.com> References: <201503300833.t2U8XKfe056489@svn.freebsd.org> <CAGHfRMADYDnStiEaEkka9SZ73F-M9Yf1KVn1JSCJbqCK3j%2Bk7Q@mail.gmail.com> <CAGHfRMC4ikAnJ_51HnJqW9FYSgofZJbjMAkXKmUdCBtOJiYO-Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/30/15 02:04, NGie Cooper wrote:
> On Mon, Mar 30, 2015 at 2:03 AM, NGie Cooper <yaneurabeya@gmail.com> wrote:
>> On Mon, Mar 30, 2015 at 1:33 AM, Colin Percival <cperciva@freebsd.org> wrote:
>>> cleanup() {
>>> + if mount | grep -qE "devfs on ${DESTDIR}/dev"; then
>>> + umount_loop ${DESTDIR}/dev 2>/dev/null
>>> + fi
>>
>> if [ -c "${DESTDIR}/dev" ]; then
>
> I meant:
>
> [ -c "${DESTDIR}/dev/null" ]
Thanks! I was looking for a way to express "if this is a mount point" but I
completely forgot that there are things which are reliably present *inside*
a devfs...
... and looking at what I committed earlier I see now that I missed a ^
at the start of the regex anyway, so my first attempt was both a bad idea
*and* wrong. ;-)
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55191267.3070305>