From nobody Tue Sep 9 15:58:00 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLpPj69Rtz6767M; Tue, 09 Sep 2025 15:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLpPj0nCRz48yp; Tue, 09 Sep 2025 15:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FM7ToALZFM+E7O6ast0fXLdD3R7iGOfRJ5vuWqdZjf8=; b=Vd8f+g954dPeFsGZgXMMYzf5JlFrVjJS9AJ30xtg61CIe9JtGjy2Gs2DmbnDQYdS0WLMWr 3z0dqBioME2fbInw3Tla7q7vIzXwZCJP8f9oHfHdDmBfYpE2jPtfmEu5LB8etazXdkxUTM rA8r8+Qh4ELYe9WV7bVKZBqDLbIv2D78y6XW3jLZ9uvrrkDesRUKMw9/gDNk5kt/euDmN0 UhrXgcw92GVHDPDxvcjGAvYcz8YWx6lh09AB9kWuh0wQy6nRko63Piu92VL5erQWFnWlYs 4iegecneMXnsxNLqBD076vhEYS9Zc8DdnE76e3hzpncrBJgKZfC4EHcQuX5YDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FM7ToALZFM+E7O6ast0fXLdD3R7iGOfRJ5vuWqdZjf8=; b=BL4YWXEpnE5ST/wdsW6swflQyDfWGPvnhsVDL6+0lyZuDuAiDlCC00HXJXphSk4eZFGCMe uh47AUDTuD6HjxUjDYSrlLtRlC3Tz/N8zZrIwxKqralWyLsnOEXzGzZ9G+wUC8biy1gZV4 aSqwef3/gK3mG63sLQgbgF2xE3lozyN9IKupMj1e0g4hps/zntIYYEE7oFXFavf/dbWC+e /OBAgDNjHBkGQHnwui13aeYzn5k1dcToJXjwOeHrVW65Kl496kr/1X4YpK7Ja5LY80Mfk8 d1Kc0JMxh1rlZiLkGCRo0dEB9u0CmMfETd4hdBWaiRFcagRy2HvwuKC8tZX/zw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757433481; a=rsa-sha256; cv=none; b=Gw244fJHqRRWr29Ybbnj5rUVPstgR8jgz7ZOBSsLIVJYB5AT2Xfj1IjIQ+D44wNZBrn/Xm Mm57fm6viWjVhTh9Q4xqzwQ1U69PMQpl1QoadiYqO3NyINICqhmqa7Sr0JPveSyfecbU8+ MRKWmzuqtgPyrdhJlAH5PPQP05qva/zNBKKx1+ilE1DhcSD18BU6MBLzrXav9rer9C3b9C WfxRFYynaCVE4/aNXoHjKzZZ8maSdmFlcD7hm/+cszXAgoESnsYeYEH2tHP+difnM5Oohl LBi4jp76AmIsvOkle/CtgcqmjhQFPXZJRLBMOaP6WZUBM+ysgyMwVFKpuvdiCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cLpPj0LqTzjbm; Tue, 09 Sep 2025 15:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 589Fw0Ec039328; Tue, 9 Sep 2025 15:58:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 589Fw0hR039325; Tue, 9 Sep 2025 15:58:00 GMT (envelope-from git) Date: Tue, 9 Sep 2025 15:58:00 GMT Message-Id: <202509091558.589Fw0hR039325@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 67f8bd5986a4 - main - nfs: newnfs_setroot(): Remove an obsolete comment List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 67f8bd5986a42a173ef9082abfcd523b1a3ac056 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=67f8bd5986a42a173ef9082abfcd523b1a3ac056 commit 67f8bd5986a42a173ef9082abfcd523b1a3ac056 Author: Olivier Certner AuthorDate: 2025-08-26 10:26:36 +0000 Commit: Olivier Certner CommitDate: 2025-09-09 15:56:47 +0000 nfs: newnfs_setroot(): Remove an obsolete comment This comment is obsolete, as: 1. This code is FreeBSD-specific and is not shared with other BSDs. 2. With our recent changes in commit be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]"), all of NetBSD, OpenBSD and FreeBSD have the effective GID in a separate field (DragonFlyBSD remains to this day an outlier). MFC after: 9 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52254 --- sys/fs/nfs/nfs_commonport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/fs/nfs/nfs_commonport.c b/sys/fs/nfs/nfs_commonport.c index e5fdb395c9f7..862780741ee7 100644 --- a/sys/fs/nfs/nfs_commonport.c +++ b/sys/fs/nfs/nfs_commonport.c @@ -371,8 +371,6 @@ nfsrv_atroot(struct vnode *vp, uint64_t *retp) /* * Set the credentials to refer to root. - * If only the various BSDen could agree on whether cr_gid is a separate - * field or cr_groups[0]... */ void newnfs_setroot(struct ucred *cred)