Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Jun 2013 11:43:20 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        William Grzybowski <wg@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r321675 - in head/net-mgmt/netdisco: . files
Message-ID:  <20130624114320.GA74688@FreeBSD.org>
In-Reply-To: <201306241119.r5OBJ3GV045211@svn.freebsd.org>
References:  <201306241119.r5OBJ3GV045211@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 24, 2013 at 11:19:03AM +0000, William Grzybowski wrote:
> New Revision: 321675
> URL: http://svnweb.freebsd.org/changeset/ports/321675
> 
> +OPTIONS_DEFINE=	DOCS GRAPHVIZ MIBS
> +OPTIONS_DEFAULT=DOCS GRAPHVIZ MIBS

DOCS option (and a few more) is already on by default, there's no need to
relist it here.

> -DOCS=		doc/*.pod doc/*.html INSTALL README* UPGRADE
> +DOCFILES=	ChangeLog doc/*.pod INSTALL README* UPGRADE

It would probably makes sense to do smth. like this:

DOCFILES=	ChangeLog doc/*.pod INSTALL README* UPGRADE
PORTDOCS=	*

post-install:
.if ${PORT_OPTIONS:MDOCS}
	${MKDIR} ${DOCSDIR}
	(cd ${WRKSRC} && ${INSTALL_DATA} ${DOCFILES} ${DOCSDIR})
.endif

And remove entries from pkg-plist.

>  	@${CAT} ${PKGMESSAGE}

It's benefitial to surround cat(1) here with @${ECHO_MSG}'s to ensure that
pkg-message is printed with consistent padding (port vs. package install).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130624114320.GA74688>