From owner-cvs-src@FreeBSD.ORG Sun Jan 29 00:08:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A38BA16A420; Sun, 29 Jan 2006 00:08:29 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from mail22.syd.optusnet.com.au (mail22.syd.optusnet.com.au [211.29.133.160]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9954E43D48; Sun, 29 Jan 2006 00:08:26 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail22.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k0T08JFs021877 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sun, 29 Jan 2006 11:08:19 +1100 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.4/8.13.4) with ESMTP id k0T08INE004452; Sun, 29 Jan 2006 11:08:18 +1100 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.4/8.13.4/Submit) id k0T08IfZ004451; Sun, 29 Jan 2006 11:08:18 +1100 (EST) (envelope-from peter) Date: Sun, 29 Jan 2006 11:08:18 +1100 From: Peter Jeremy To: Wilko Bulte Message-ID: <20060129000818.GF2341@turion.vk2pj.dyndns.org> References: <200511232322.jANNMuGE005810@repoman.freebsd.org> <20051208024017.GA32302@dragon.NUXI.org> <20060128055725.GA83856@dragon.NUXI.org> <20060128223343.GE2341@turion.vk2pj.dyndns.org> <20060128225700.GA88332@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060128225700.GA88332@freebie.xs4all.nl> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: Craig Rodrigues , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount Makefile extern.h mount_ufs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 00:08:29 -0000 On Sat, 2006-Jan-28 23:57:00 +0100, Wilko Bulte wrote: >On Sun, Jan 29, 2006 at 09:33:43AM +1100, Peter Jeremy wrote.. >> On Fri, 2006-Jan-27 21:57:25 -0800, David O'Brien wrote: >> >On Wed, Dec 07, 2005 at 06:40:17PM -0800, David O'Brien wrote: >> >> On Wed, Nov 23, 2005 at 11:22:56PM +0000, Craig Rodrigues wrote: >> >> > rodrigc 2005-11-23 23:22:56 UTC >> >> > >> >> > FreeBSD src repository >> >> > >> >> > Modified files: >> >> > sbin/mount Makefile extern.h >> >> > Removed files: >> >> > sbin/mount mount_ufs.c >> >> > Log: >> >> > Remove UFS-specific parts from mount(8). >> >> > For mounting UFS, all mount options are passed directly to nmount(), >> >> > without any UFS-specific logic. >> >> >> >> Where do we stand on making 'mount /' from single user work again? >> > >> >Can you give us an update on where you stand on making 'mount /' work >> >again from single user? We've been suffering from this for 2 months now. >> >> "mount -r" also no longer works if the FS is marked "rw" in /etc/fstab. >> Instead you have to use "mount -o norw". How about having "ro" imply >> "norw" and vice versa. > >Blurk.. norw == ro and noro == rw? What is wrong with just sticking with >plain and simple rw and ro ? ro and rw still exist but, based on my reading of the code, the options you enter are appended to the options in fstab so that if you say "mount -r" (or "mount -o ro"), nmount(2) is passed "rw,ro" and the "rw" over-rides the "ro". "norw" makes mount(8) strip the "rw" and then nmount(2) defaults to ro. I think mount(8) needs to grow some special-casing so that it knows that "ro" and "rw" are complementary. -- Peter Jeremy