From owner-freebsd-bugs@freebsd.org Thu Aug 31 10:25:08 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C2C7E1B4A9 for ; Thu, 31 Aug 2017 10:25:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 092B8721F4 for ; Thu, 31 Aug 2017 10:25:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7VAP7gA059105 for ; Thu, 31 Aug 2017 10:25:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221957] cam iosched: Add a handler for the quanta sysctl to enforce valid values Date: Thu, 31 Aug 2017 10:25:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 10:25:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221957 Bug ID: 221957 Summary: cam iosched: Add a handler for the quanta sysctl to enforce valid values Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: fk@fabiankeil.de Flags: mfc-stable11? Created attachment 185948 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185948&action= =3Dedit cam iosched: Add a handler for the quanta sysctl to enforce valid values The attached patch adds a handler for the iosched quanta sysctl to enforce valid values Invalid values can result in devision-by-zero panics and other undesirable behaviour. Example panic: Fatal trap 18: integer divide fault while in kernel mode cpuid =3D 0; apic id =3D 00 instruction pointer =3D 0x20:0xffffffff802998e5 stack pointer =3D 0x28:0xfffffe01ea3bf8d0 frame pointer =3D 0x28:0xfffffe01ea3bf900 code segment =3D base 0x0, limit 0xfffff, type 0x1b =3D DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags =3D interrupt enabled, resume, IOPL =3D 0 current process =3D 12 (swi4: clock (0)) trap number =3D 18 panic: integer divide fault cpuid =3D 0 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe01ea3bf510 vpanic() at vpanic+0x186/frame 0xfffffe01ea3bf590 panic() at panic+0x43/frame 0xfffffe01ea3bf5f0 trap_fatal() at trap_fatal+0x322/frame 0xfffffe01ea3bf640 trap() at trap+0x5e/frame 0xfffffe01ea3bf800 calltrap() at calltrap+0x8/frame 0xfffffe01ea3bf800 --- trap 0x12, rip =3D 0xffffffff802998e5, rsp =3D 0xfffffe01ea3bf8d0, r= bp =3D 0xfffffe01ea3bf900 --- cam_iosched_ticker() at cam_iosched_ticker+0x25/frame 0xfffffe01ea3bf900 softclock_call_cc() at softclock_call_cc+0x13e/frame 0xfffffe01ea3bf9b0 softclock() at softclock+0xb9/frame 0xfffffe01ea3bf9e0 intr_event_execute_handlers() at intr_event_execute_handlers+0xec/frame 0xfffffe01ea3bfa20 ithread_loop() at ithread_loop+0xd6/frame 0xfffffe01ea3bfa70 fork_exit() at fork_exit+0x85/frame 0xfffffe01ea3bfab0 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe01ea3bfab0 --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- Uptime: 2h29m20s Dumping 1165 out of 8055 MB:..2%..11%..21%..31%..42%..51%..61%..71%..81%..91% Obtained from: ElectroBSD --=20 You are receiving this mail because: You are the assignee for the bug.=