From owner-freebsd-current@freebsd.org  Thu Jan 12 18:30:49 2017
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A080CAB036
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Thu, 12 Jan 2017 18:30:49 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7A6741B55
 for <freebsd-current@freebsd.org>; Thu, 12 Jan 2017 18:30:49 +0000 (UTC)
 (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 1FB9610B4D1;
 Thu, 12 Jan 2017 13:30:48 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Cc: Shawn Webb <shawn.webb@hardenedbsd.org>,
 Jakob Alvermark <jakob@alvermark.net>
Subject: Re: r311568 makes freerdp very slow
Date: Thu, 12 Jan 2017 10:26:07 -0800
Message-ID: <1610370.k87iRho0oa@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; )
In-Reply-To: <20170112174211.5nmvpjatg6zap35a@mutt-hardenedbsd>
References: <57236.193.12.143.142.1484240708.squirrel@webmail.alvermark.net>
 <20170112174211.5nmvpjatg6zap35a@mutt-hardenedbsd>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Thu, 12 Jan 2017 13:30:48 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2017 18:30:49 -0000

On Thursday, January 12, 2017 12:42:11 PM Shawn Webb wrote:
> On Thu, Jan 12, 2017 at 06:05:08PM +0100, Jakob Alvermark wrote:
> > Hi,
> > 
> > r311568 Set MORETOCOME for AIO write requests on a socket.
> > 
> > After this commit freerdp is very slow.
> > 
> > Before the password prompt would appear immediately when connecting to a
> > server. Now it takes 5-10 seconds. After entering the password, another
> > 5-10 seconds until I am connected.
> > Once connected, there is a considerable lag.
> > 
> > What could be the problem?
> 
> I don't know what the problem is, but I am seeing the same symptom.

Can you get a ktrace of the freerdp process during this?  The commit
should only be setting MORETOCOME if multiple aio_write requests are
queued to the same socket (so that TCP can batch them into a single
packet).  However, it should not affect an application just calling
aio_write() on a socket once.

-- 
John Baldwin