Date: Tue, 15 Aug 2000 22:20:02 -0700 (PDT) From: Kim Scarborough <sluggo@unknown.nu> To: freebsd-ports@FreeBSD.org Subject: Re: ports/20618: New port: moviedb, the internet movie database Message-ID: <200008160520.WAA71793@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/20618; it has been noted by GNATS.
From: Kim Scarborough <sluggo@unknown.nu>
To: Will Andrews <andrews@technologist.com>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/20618: New port: moviedb, the internet movie database
Date: Wed, 16 Aug 2000 00:14:48 -0500 (CDT)
Thanks for the quick reply & the notes.
> > # /usr/ports/misc/moviedb
>
> Should not be in the shar because it forces position. Like, maybe
> people would prefer to put it in a working directory or something
> instead of here.
Oh, whoops... wasn't thinking about that. I'll send a new one from the
relative path, like you say.
> > XDISTFILES= tools/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} actors.list.gz actresses.list.gz aka-names.list.gz aka-titles.list.gz alternate-versions.list.gz biographies.list.gz business.list.gz certificates.list.gz cinematographers.list.gz color-info.list.gz complete-cast.list.gz complete-crew.list.gz composers.list.gz costume-designers.list.gz countries.list.gz crazy-credits.list.gz directors.list.gz distributors.list.gz editors.list.gz genres.list.gz german-aka-titles.list.gz goofs.list.gz iso-ak a-titles.list.gz italian-aka-titles.list.gz keywords.list.gz language.list.gz laserdisc.list.gz literature.list.gz locations.list.gz miscellaneous.list.gz movie-links.list.gz movies.list.gz mpaa-ratings-reasons.list.gz plot.list.gz producers.list.gz production-companies.list.gz production-designers.list.gz quotes.list.gz ratings.list.gz release-dates.list.gz running-times.list.gz sound-mix.list.gz soundtracks.list.gz special-effects-companies.list.gz taglines.list.gz techni!
cal.!
>
> This is a big no-no (wrapping lines unnecessarily). Use this:
I'll fix that too.
> DISTFILES= tools/${DISTNAME}${EXTRACT_SUFX} ${IGNOREFILES}
>
> > X ${INSTALL_SCRIPT} ${WRKSRC}/etc/lfetch ${PREFIX}/libexec/moviedb/
> > X ${INSTALL_SCRIPT} ${WRKSRC}/etc/make-base ${PREFIX}/libexec/moviedb/
> > X ${INSTALL_SCRIPT} ${WRKSRC}/etc/recompress ${PREFIX}/libexec/moviedb/
>
> Use a for script (in make syntax) to prevent repetition and make the
> Makefile more scalable.
> .for SCRIPT in lfetch make-base recompress
> ${INSTALL_SCRIPT} ${WRKSRC}/etc/${SCRIPT} ${PREFIX}/libexec/moviedb
> .endfor
Will do.
> > XMD5 (moviedb/actors.list.gz) = IGNORE
(etc.)
> I'm not sure I like the idea of the MD5 checksums of these files being
> ignored...
They have to be... those files change every few days, as new information
is added.
> > XPLEASE NOTE! This is a large port; as of August 2000, it requires over
> > X300MB free to install.
>
> Probably should move this to the Makefile, in pre-fetch target, so
> people will have a chance to cancel if they wish, before they download
> things.
I thought about doing that, and I'm not sure why I decided against it. I
will put it there.
> There are some minor tweaks I'd suggest in the patches, like using sed
> or perl regex in the Makefile for removing some of the options instead
> of having to recreate patchfiles every time you update (i.e. make the
> port more scalable across new versions).
Well, I'm kinda hoping that they'll figure out the stupidity of having
variables in the Makefile that break the compile if redefined... if that
someday occurs to them, most of those patches will become unnecessary.
Look for the new shar soon. BTW, has anyone there had a chance to look at
my quranref port?
-------------------------------------------------------------------------------
Kim Scarborough http://www.unknown.nu/kim/
-------------------------------------------------------------------------------
"For every complex problem there is a simple solution, and it's wrong."
- H. L. Mencken
-------------------------------------------------------------------------------
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008160520.WAA71793>