Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 05 Jun 2005 10:49:11 +0200
From:      Martin <nakal@nurfuerspam.de>
To:        Matt Emmerton <matt@gsicomp.on.ca>
Cc:        freebsd-current@freebsd.org
Subject:   Re: Optimizing libc/string for amd64(?)
Message-ID:  <42A2BC87.5040103@nurfuerspam.de>
In-Reply-To: <000701c5696f$0dee3b10$1200a8c0@gsicomp.on.ca>
References:  <42A242D1.4000002@nurfuerspam.de> <000701c5696f$0dee3b10$1200a8c0@gsicomp.on.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
Matt Emmerton wrote:

>>Wouldn't it be better to set it to "typedef long word"?

> It would probably be better to use int64_t and int32_t instead of long/int,
> in order to make the intention more obvious.

The decision up to the developers. I personally would still use
"long", because it is auto-adjusting and has always the size of
the word on the concerning architecture, AFAIK. I usually try to
avoid ifdefs, whereever it is possible. But there might be already
some other places in the whole codebase where the type for word has
been already computed. It would be even better to use that, because
then it is done just in one place.

But before thinking about a change, it would be better if someone
confirms the degraded performance (just run nbench). I've only checked
it on 1 machine and cannot access it very often (it does not belong
to me).

Martin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42A2BC87.5040103>