From owner-svn-src-all@FreeBSD.ORG Sun Mar 13 06:47:12 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99AA31065670; Sun, 13 Mar 2011 06:47:12 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 08D4B8FC0A; Sun, 13 Mar 2011 06:47:11 +0000 (UTC) Received: by qwc9 with SMTP id 9so709951qwc.13 for ; Sat, 12 Mar 2011 22:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DvsGSHRraHOrD1r6ezjPh7oEpCoYfHNoVfv4cV2NVYU=; b=Hgt5X2ucJbOl6BijjmLTw7yg40dkAJXo7Tf+QGMxCtSarLPted9wgiShrhrZY7VR0S yrPGBnmvWFnd/8BrNU0CfQNMkK3ckiOiH8CvCkpd3VMTgXslEM3Om94v3wy2TP/piHsM qmPmyIM/ZcUCoyJleeICQfm9AyB0z/UJgGUK0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=CgXsfsFPw5X9/AYMi6h7uGo+TM8FUvWZ9Dr4BaC0IX1/+hHGjV7H9QsX7WWMsmT1DI Q3V2TtUqedWRM5cLKIwLMBHd1rnybg9buFIlZXiD2enCXkyNumRixLYSRRXiqZ+qDFBK /3IYjNsz1arnbzV4dPKXh64tnRcv5HhoVH0vw= MIME-Version: 1.0 Received: by 10.229.0.202 with SMTP id 10mr136630qcc.173.1299997449607; Sat, 12 Mar 2011 22:24:09 -0800 (PST) Sender: artemb@gmail.com Received: by 10.229.31.83 with HTTP; Sat, 12 Mar 2011 22:24:09 -0800 (PST) In-Reply-To: <20110312205719.00004e67@unknown> References: <201103120851.p2C8phoN010341@svn.freebsd.org> <20110312205719.00004e67@unknown> Date: Sat, 12 Mar 2011 22:24:09 -0800 X-Google-Sender-Auth: BEU7Dt3oqfeYFWiioPw_9dHpv3I Message-ID: From: Artem Belevich To: Alexander Leidinger Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andriy Gapon Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2011 06:47:12 -0000 > I assume this also includes syscall provider support for linux syscalls > on i386. Some questions below. Yes. > >> Modified: head/sys/i386/linux/syscalls.master >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 l_hand= ler_t handler); } >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 void *= handler); } > > What's wrong with l_handler_t? I don't recall the details, but I believe that the way l_handler_t is defined resulted in compilation errors in generated glue code. Glue generation code relies on '*' before the argument name in order to tell scalars from pointers. l_handler_t was interpreted as a scalar and on i386 where l_handler_t is a pointer, it produced compilation warning. > >> @@ -148,7 +148,7 @@ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 stru= ct timeval *tp, \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 stru= ct timezone *tzp); } >> =A079 =A0 AUE_SETTIMEOFDAY =A0 =A0 =A0 =A0NOPROTO { int >> settimeofday( \ >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct= timeval *tp, \ >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct= timeval *tv, \ > > What's wrong with tp? settimeofday_args has the field named tv. With the argument named tp in the syscalls.master, the glue code generated for systrace provider would attempt to use settimeofday_args->tp and that does not compile. We rely on syscall argument names in syscall.master to match field names in appropriate _args. --Artem