From owner-svn-src-head@FreeBSD.ORG Tue Sep 10 18:26:36 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A3F5178F; Tue, 10 Sep 2013 18:26:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7A02B2059; Tue, 10 Sep 2013 18:26:36 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E6010B968; Tue, 10 Sep 2013 14:26:33 -0400 (EDT) From: John Baldwin To: obrien@freebsd.org Subject: Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni Date: Tue, 10 Sep 2013 14:22:01 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <201309031831.r83IVNkh026523@svn.freebsd.org> <20130910064149.GS68682@funkthat.com> <20130910165127.GA69190@dragon.NUXI.org> In-Reply-To: <20130910165127.GA69190@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201309101422.01635.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 10 Sep 2013 14:26:34 -0400 (EDT) Cc: src-committers@freebsd.org, re@freebsd.org, John-Mark Gurney , Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 18:26:36 -0000 On Tuesday, September 10, 2013 12:51:27 pm David O'Brien wrote: > On Mon, Sep 09, 2013 at 11:41:49PM -0700, John-Mark Gurney wrote: > > David O'Brien wrote this message on Mon, Sep 09, 2013 at 23:01 -0700: > > Please back that out until you have an understand of what the real > > problem is... > > Folks use FreeBSD for real work -- I have a window of opportunity to > install a new world + kernel. When I tried updating this laptop in > early August the kernel build was broken. It appeared broken again > this time. > > The issue is you added a new feature to the GCC compiler > (r255185 2013-09-03), and then immediately consumed it in the kernel > build (r255187 2013-09-03 11:31:23). You did not put anything in > UPDATING warning folks of this. > > > Robert Watson used to often remind folks that when we add features to > the toolchain we give a reasonable amount of time for them to work > their way into folks userland before using them in the kernel build. > > > My userland sources are from Sunday September 1st when I started my > 'make buildworld' + 'mergemaster -p' + 'make installworld' + > 'mergemaster -i' sequence. Sorry it takes so long to build world with > clang on a T60. I updated my kernel sources and tried to build a new > kernel before rebooting. I had no reason to not expect a 2 day old > compiler could not build a kernel during a code freeze. Err, you are running head. If you get a compile failure when you have updated your kernel to newer than world, your first reponse should be to make your kernel sources match your world, not committing an untested change. Also, the level of change in the tree is always the _worst_ right at code freeze. You can debate whether or not it should be that way, but in practice it always is and you should know better. -- John Baldwin