From owner-freebsd-arch Thu Jan 31 7:38:26 2002 Delivered-To: freebsd-arch@freebsd.org Received: from shidahara1.planet.sci.kobe-u.ac.jp (shidahara1.planet.sci.kobe-u.ac.jp [133.30.68.253]) by hub.freebsd.org (Postfix) with ESMTP id 1440B37B41C for ; Thu, 31 Jan 2002 07:38:17 -0800 (PST) Received: from shidahara1.planet.sci.kobe-u.ac.jp (localhost [127.0.0.1]) by shidahara1.planet.sci.kobe-u.ac.jp (8.9.3/8.9.3) with ESMTP id AAA31332 for ; Fri, 1 Feb 2002 00:36:36 +0900 (JST) (envelope-from takawata@shidahara1.planet.sci.kobe-u.ac.jp) Message-Id: <200201311536.AAA31332@shidahara1.planet.sci.kobe-u.ac.jp> To: arch@freebsd.org Subject: Re: How about removing #ifdef DEV_ISA from autoconf.c In-reply-to: Your message of "Thu, 31 Jan 2002 06:50:09 +1100." <20020131064141.X55787-100000@gamplex.bde.org> Date: Fri, 01 Feb 2002 00:36:36 +0900 From: Takanori Watanabe Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020131064141.X55787-100000@gamplex.bde.org>, Bruce Evans さんいわ く: >On Thu, 31 Jan 2002, Takanori Watanabe wrote: > >> Hi, I have a patch to be reviewed. >> This removes #ifdef DEV_ISA from sys/i386/autoconf.c and >> allows to intercept before and after isa_prove_children() executed. >> This will enable us statisize isa_probe_children, though what I want to do >> is to execute isa_probe_children-like routine in acpi module >> after isa_probe_children is exeuted. >> >> This patch contains patch to i386/i386/autoconf.h and isa/isa_common.c and >> new sys/autoconf.h file. >> >> How do you think about it? > >The complications to get interrupts enabled at the correct time aren't >needed in -current since spl0() has no effect. Interrupts are enabled >at incorrect times earlier :-). I guess masking in the ICU prevents >serious problems. Hmm, I know spl0() is no effect any more, some stubs will need to disable/enable during autoconfiguration. Or should it be in configure_final()? BTW, I update the patch that can be apply for other archtectures. (alpha,ia64,i386) http://people.freebsd.org/~takawata/isadiff http://people.freebsd.org/~takawata/autoconf.h Takanori Watanabe Public Key Key fingerprint = 2C 51 E2 78 2C E1 C5 2D 0F F1 20 A3 11 3A 62 2A To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message